• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Unhelpful - 2008-12-21
Last edited by Unhelpful - 2009-01-17

FS#9689 - greylib pictureflow for greyscale targets

This patch allows pictureflow to be used on greyscale (but not mono) targets using greylib, and the new greylib scaler. It requires the recent updates from  FS#9458 , and the scaler output plugging support and greylib output plugin from  FS#9683 . It incorporates my previous pictureflow scaling patch from  FS#9665 , which does not apply cleanly over the other two patches.

The tracklist and album view work exactly as on color targets, in greyscale. The greylib overlay is disabled in the config menu, as this does not rely on color. I have tested on Mini 2G and iPod 4G sims, as well as on iPod video sim (to verify color works correctly).

The task depends upon
ID Project Summary Priority Severity Assigned To Progress
9458 Rockbox  FS#9458 - resize bitmap on load with smooth scaling  Very Low Low
9683 Rockbox  FS#9683 - pluggable scaler output for greylib  Very Low Low
Closed by  Unhelpful
2009-01-17 00:38
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

this work was committed in r19598

Reordered loops while creating reflection, so that some math can be moved out of the inner loop. Also made the scaling factor used for the reflection a constant, and of lower precision, to replace a 32×32→64 multiply with a →32 one.


Available keyboard shortcuts


Task Details

Task Editing