Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Rbutil
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pyro_maniac - 2008-12-21
Last edited by bluebrother - 2009-01-08

FS#9695 - Rockbox Utility - German Translation

This patch completes the german translation for the qt version of the rockbox utility.

Closed by  bluebrother
2009-01-08 16:30
Reason for closing:  Rejected
Additional comments about closing:  

see comments.

Can you please clarify what this patch does complete? As far as I can see it only marks translations as finished that have been left in the "unfinished" state (which I did intentionally). The translation will be used nevertheless (unless -nounfinished is used when calling lrelease, which isn't done).

No there is no translation left. And i not only finished up the translations, i also made a change.

- Aktuell installierte Pakete.&lt;br/&gt;&lt;b&gt;Hinweis:&lt;/b&gt; wenn Pakete manuell installiert wurden wird diese Anzeige nicht korrekt sein!</translation>
+ Aktuell installierte Pakete.&lt;br/&gt;&lt;b&gt;Hinweis:&lt;/b&gt; Wenn Pakete manuell installiert wurden, könnte diese Anzeige nicht korrekt sein!</translation>

biggest change ever. but why were the strings all marked with unfinished?

the patch adds <defaultcodec></defaultcodec>, i dont know whether this is useful….

I don't know if you used the tools of QT but this is the way it works. There is no "finish" tag for translations. Unmarked translations are set to finish and the defaultcodec tag was set by the qt4 linguist itself.

the question was why they were tagged with "unfinished"….

I am not shure but sometimes small changes on the string or in the code make the lupdate to tag this with "unfinished". I cant really say what happed.

Translations can get marked as finished or unfinished in linguist. In this case I intentionally left some translations with the status unfinished (stated above already) as I wasn't too happy with them and just used this as marking for myself to look over them again later.

Also, I disagree with the changed line – if you install packages manually the info tab *will* be wrong, it's not that it *might* be. Unless someone explains me why this change should be made the next couple of days I'm going to reject this patch.

Do you disagree with the translation or with a change on the original file?

I disagree with the translation.

In my opinion it must be a "might" because there is no guarantee that that the informations are wrong for manual installations. Maybe this describes it best.

"if you install packages manually the info tab *will* be wrong, it's not that it *might* be. "

i think dominik wrote it quite clearly, didnt he? i suggest closing (of this task).

Sorry i might had to read it twice to understand it. I was focused to much on the translation then on how it really is. So you might close it with the result that the translations are good as they are in my opinion.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing