Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Simulator
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by idak - 2008-12-26
Last edited by nls - 2009-01-24

FS#9717 - Fix "warning: "htobe16" redefined"

I think newer? SDL includes <endian.h>
(my fedora10’s SDL version is 1.2.13),
and simulator build log says like the following.
— warning: “htobe16” redefined
http://build.rockbox.org/showlog.cgi?date=20081226T160730Z&type=iAudio%20M3%20-%20Simulator#prob1 — This patch fix it.

Closed by  nls
2009-01-24 10:17
Reason for closing:  Accepted
Additional comments about closing:  

Committed with funman's suggested change, thanks!

You don’t need to check if a symbol is defined before undefining it, simply use “#undef xxx”

However I think sdl.h should be checked to see if some macro can prevent inclusion of endian.h

MikeS commented on 2009-01-08 11:44

I think ‘#define _ENDIAN_H’ somewhere before including headers would prevent it (as a -D_ENDIAN_H perhaps).

idak commented on 2009-01-08 14:40

I think -D_ENDIAN_H is not good, because endian.h defines other thins like “__BYTE_ORDER”.
And if it doesn’t defined, a lot of error is printed.

If it’s enclosed into #ifdef SIMULATOR (because only the sim use SDL) I think this should be good.

Michael what do you think ?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing