Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2009-01-05
Last edited by bertrik - 2009-01-31

FS#9763 - Sansa Clip modified WPS

The Sansa Clip has a 128x64x1 display and currently re-uses the remote cabbiev2 WPS for Iriver players. A unique feature of the Clip display is that it is split up in two sections, an upper 128×16 yellow section, then two empty lines and a lower 128×48 cyan section. This results in the problem that the title/artist/album info in the current cabbiev2 WPS gets split up between the yellow and the cyan part, making it look ugly and harder to read.

This patch gives some suggestions for an alternative cabbiev2 128x64x1 WPS, more suitable for the Sansa Clip screen.

Screenshot clip_wps_org.png shows how the WPS currently looks on the Clip.
Patch wps_clip.patch moves the “X of Y” and “MM:SS” progress text up in the yellow part, such that the title/artist/album info is no longer split, see screenshot clip_wps.png
Patch wps_clip2.patch simply moves the title/artist/album a little lower, see screenshot clip_wps2.png.

Closed by  bertrik
2009-01-31 12:25
Reason for closing:  Accepted
Additional comments about closing:  

Committed with minor fixes as svn r19889

I like a lot the first patch !!

I discussed with pixelma and she said that these diffs must be specific to the Clip, and not applied to other 128x64x1 screens (because they use a font size 9 by default for example).

I believe a simple patch to wpsbuild.pl could look for a cabbiev2-resolution-model.wps before cabbiev2-resolution.wps

How’s that one? I like that slightly more.

Just to say what’s different between your first and my one:
the bar is 1-2 pixel more up, the tag ingo 1-2 pixel more down, which makes the tag info a bit more centered (and eye-friendly ;) )

Attached patch updates the root.make, buildzip.pl and wpsbuild.pl scripts to preferentially select theme.resolution.modelname.wps over theme.resolution.wps (for example cabbiev2.128x64x1.clip.wps is chosen instead of cabbiev2.128x64x1.wps). Also included is the cabbiev2.wps suggested by kugel, with a fix to the “now playing” text (shifted 1 pixel down).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing