Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Boris Gjenero - 2009-02-02
Last edited by Andree Buschmann - 2009-02-22

FS#9863 - Disk not spun down properly when rebooting for USB

I have a 5th generation 30GB iPod with a stock MK3008GAL hard drive. If the disk is off when plugging in the USB cable, I hear the click-whine of the emergency head retract when rebooting. This should probably be avoided because it may wear out the disk more than normal head retracts.

In drivers/ata.c in ata_thread() when responding to SYS_USB_CONNECTED, the disk is turned on if it was off. However, no variables are changed to let ata.c know that the disk has been turned on, and so ata_sleepnow() won’t put it to sleep. Another consequence would be that settings don’t get saved. The disk is also not woken up if it was powered but sleeping, and this may be another bug. I am attaching a patch for these issues.

I am also wondering what’s the point of spinning up the disk. I think it only needs to be spun up if settings need to be saved.

Closed by  Andree Buschmann
2009-02-22 13:25
Reason for closing:  Accepted
Additional comments about closing:  

Submitted with r20082.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing