Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System PortalPlayer-based
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lowlight - 2009-02-02
Last edited by nls - 2009-02-14

FS#9865 - PortalPlayer i2c multi-byte reads

The Portalplayer i2c controller can read/write up to 4 bytes of data at a time. The current svn code does multi-byte writes (sends), however, when reading, it always requests 1 byte at a time.

While working on the Philips hdd1630 radio (tea5767 connected via i2c), I found that it doesn’t like this method of i2c communication. When reading from the tea5767, you need get 4 bytes at once or else, with the current code, you only get the first byte over and over again.

Since this potentially impacts all Portalplayer devices, I’ll put the patch here for some testing just to be cautious. Looks like effected drivers are pcf50605 (ipods), rtc_e8564 (h10 & hdd1630), and as3514 devices (sansas). I tested it on the hdd1630 (PP5022B), sansa c200 (PP5022C), and m:robe 100 (PP5020E) with seemingly no bad results. I suspect that the PP502x players are fine, but I’m unsure about the ipods, particularly PP5002’s.

Closed by  nls
2009-02-14 23:39
Reason for closing:  Accepted
Additional comments about closing:  

This patch was committed as r19995

iPod 5.5G behaves normally. Though i’ve no idea what to expect if the i2c controller acts wired.

3G iPod (PP5002) seems to work too. However the menu button doesn’t work anymore, though hard reset still works. But the menu button doesn’t work in the OF either so I guess that doesn’t have anything to do with the i2c.

Sansa e200 behaves normally with this patch applied.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing