Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Music playback
  • Assigned To No-one
  • Operating System Gigabeat F/X
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MJT - 2009-02-02
Last edited by MichaelGiacomelli - 2009-07-01

FS#9866 - .ogg file(s) reliably crashes Rockbox on Gigabeat F40

I have a Gigabeat F40 running version r19888.090130. I am not using the database feature. On certain .ogg files, the player freezes immediately (zero time elapsed), and must be restarted by switching the battery switch. It is a specific set of files that cause the freeze, and not all .ogg files have the same effect–some play fine. When converted to mp3, the files cause no problem.

I posted this initially in the forum (http://forums.rockbox.org/index.php?topic=20456.0), and was advised to open a bug. I can also send a file if you advise how and where.

Closed by  MichaelGiacomelli
2009-07-01 17:49
Reason for closing:  Fixed
Additional comments about closing:  

Should be fixed.

MichaelGiacomelli commented on 2009-02-03 01:47

If possible, attach it to the task you just opened. If not, either upload it to some other hosting or email me a copy.

MJT commented on 2009-02-06 20:11

Have you received the file on RapidShare?
Thanks.

MJT commented on 2009-02-16 00:02

A sample file that causes the problem described can be found at
http://rapidshare.com/files/194475757/01_-_The_Eve_Of_The_War.ogg.

Thanks.

Magnus Holmgren commented on 2009-02-17 18:05

This happens because:

* The Vorbis comments contain a big album art image. In this case, about 0.5 MB.
* The Vorbis decoder always loads all comments, even though Rockbox doesn’t get them from the decoder (thus, memory is wasted; in this case, lots of memory).
* Rockbox has limited amounts of memory for dynamic allocations by the codec.
* The Vorbis decoder doesn’t check for memory allocation failure in this case.

So, the quick fix is, dump the album art image. By the way, Vorbis comments are “meant for short, text comments, not arbitrary metadata”. I can’t say I like the practice of dumping images in them. :)

MJT commented on 2009-03-01 19:15

Thank you!

Dave Chapman commented on 2009-03-01 22:11

r20156 fixed this by truncating large comments, but the codec shouldn’t be parsing/loading the vorbis comments in the first place - all it needs to do is skip them.

MichaelGiacomelli commented on 2009-03-02 01:05

This patch sets the comments length to zero for all files to avoid wasting memory storing metadata in the codec itself. However, it does advance the file pointer past the comments. Somewhat surprisingly, this doesn’t seem to matter for my couple files, but it would be nice if someone with a larger vorbis collection could test it out a bit just to make sure its ok for all files.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing