Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Plugins
  • Assigned To No-one
  • Operating System Sansa e200
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2009-02-07
Last edited by jdgordon - 2009-02-13

FS#9877 - Can't quit the lamp plugin

r19933: the lamp plugin can only be left via shutdown (long press of POWER), at least on my Sansa e200. All other buttons are ignored.

BTW: there is the patch FS#8934 that implements switching the lamp on and off. Why isn’t it committed?

Closed by  jdgordon
2009-02-13 00:17
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

shold be fixed in r19992.

Llorean commented on 2009-02-07 15:56

What button is supposed to exit Lamp on the e200?

Also, please don’t use flyspray as a method of asking “why isn’t X committed?” If you feel a patch should be committed, send an email to the -dev mailing list with the patch, and stating your willingness to do the work necessary to fix up whatever objections the developers have. “Patch X isn’t committed yet” is not a bug, and does not belong here even as a footnote.

tri170391 commented on 2009-02-07 16:28

According to this: http://download.rockbox.org/manual/rockbox-sansae200/rockbox-buildch11.html#x14-25700011.4.8 It’s the power button. I can confirm this too.

Jaykay commented on 2009-02-09 18:16

introduced in r19925: Fix a wrong check in lamp, spotted by DerPapst

maybe the check is now wrong :)

fml2 commented on 2009-02-11 15:36

I think the comment by tri170391 about the quit button is not correct. Any key not assigned a special function should quit the plugin.

tri170391 commented on 2009-02-12 05:03

It’s what said in the manual, but you are right it’s any button other than select will do the job.

Mystic_kitsune commented on 2009-02-12 12:43

i can confirm, and i have 2 observations; 1) not all the buttons are ignored, both the left/right keys and the scroll wheel still work, as well as the lock still responds, and 2) the menu is shown a split second, along with the “Shutting down…” dialog, for a fraction of that. beyond that, im kinda baffled.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing