• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2009-02-07
Last edited by nls - 2009-03-28

FS#9878 - Don't let the lamp plugin compile for players without backlight

This patch lets the compiler to issue a compile error when the lamp plugin is built for a player without the backlight feature.

Without this patch, the whole file is #ifdef’ed out so that there will be no plugin entry point. The patch makes the compile process fail with a describing error message.

Closed by  nls
2009-03-28 17:00
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

deleted the check altogether in r 20563

Surely it would make more sense to not compile it at all (by ifdeffinng it out of apps/plugins/SOURCES)?

fml2 commented on 2009-02-07 21:22

It’s ifdeff’ed there. This is just an additional security check.

I don’t understand. lamp.c should never be processed…why the “additional security check”?

fml2 commented on 2009-02-16 20:47

Yes, lamp.c is ifdeffed out in the SOURCES file. So it might be better to remove the check in the .c file itself. But it contained one. This patch just makes the check better. But, as I said, it could/should be removed alltogether.


Available keyboard shortcuts


Task Details

Task Editing