• Status Unconfirmed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2009-02-07

FS#9879 - Quit the lamp plugin by pressing a dedicated QUIT button

As of r19940, the lamp plugin is quit by pressing any key besides some which have a function in that plugin (or so is the intention –see bug report  FS#9877 ).

This patch changes the plugin so that it’s left with a special button only. The patch also adds key definitions for some players that haven’t been included before (players without color LCD). Key mappings were taken from the patch in FS#8934.

Essentially, this patch implements an atomic part of that patch.

Also, correct handling of USB has been added.

This is in preparation of a (separate) patch for toggling the light on and off without leaving the plugin.

It's a feature that any button any button exits it! Why change that?

fml2 commented on 2009-02-09 20:01

Not any button exits. Some buttons have other funcs (switching color only – now). If we introduce the feature ON/OFF then, I think, the exit button should be defined explicitly and not as "any button not assigned a function."

Not in my opinion. I like that any button exits it (yes, except for the ones that change the color..)


Available keyboard shortcuts


Task Details

Task Editing