• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2009-02-08
Last edited by teru - 2011-01-24

FS#9883 - Correct the function for forcing the backlight ON and add a func to force it OFF

The implementation of the force_backlight_on was not correct IMO. If the current setting value is OFF then calling the function wouldn’t have any effect.

Closed by  teru
2011-01-24 12:40
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

bl_helper.diff is committed as r29128.

Not sure if this is really a bug.

This would hit only targets where the screen is readable without backlight. And if the user decided against backlight at all, it shouldn’t be turned off, not even forced, I suppose. On the other targets (where you need backlight to read the screen), disabling backlight at all isn’t a valuable option anyway (except for blind users maybe) and thus this wouldn’t change anything.

fml2 commented on 2009-02-10 18:45

IMO the whole point of the force functions is to override the current settings whatever they are. My view is confirmed by the fact that the lamp plugin does not work if the BL setting is set to OFF (try it on e.g. H120).

fml2 commented on 2009-02-11 07:07

For possible readers: See also discussion in IRC starting at and ending ~22:15.

I like the idea of renaming it to ignore_backlight_timeout() - i.e. making a “timed out” backlight be in the on state, not the off state. If the user configures the backlight off always, or off on hold, then that is still respected.

Personally, on my H300, I configure backlight on a 20s timeout, plus off if HOLD is on. I’d want it to stay on during the plugin, but turn off when I enable the hold switch (and back on again when I disable it, of course).

buttonlight_force_on also does nothing when the buttonlight timeout is set to Off, causing the buttonlight functionality of the lamp plugin to fail. The same changes (if x != newvalue instead of if x > 0) could be applied to this function as well. I have the buttonlight switched off on my Sansa because I find it too bright - but when running lamp, bright lights are exactly what I want!

teru commented on 2011-01-20 14:28

i think this change is reasonable.
* rename backlight_force_on to backlight_ignore_timeout to make the name suit what the function does.
* add function backlight_force_on that actually forces baclight to turn on and use this in lamp plugin.
in the other words, nothing is changed except lamp plugin always turn on the backlight.

i’d like to commit this in few days if no one object to.
if there are other plugins which make sense to force backlight on, then we can change them later.


Available keyboard shortcuts


Task Details

Task Editing