FS#9894 - Position of the progress bar is not updated after the font is changed

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Wednesday, 11 February 2009, 19:02 GMT
Last edited by Thomas Martitz (kugel.) - Monday, 16 February 2009, 08:37 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The problem occurs with r19974, at least in the simulators for e200 and h120.

I use the following WPS code which can be used with many fonts:





Now, how to reproduce:
1. Start playing a file
2. Go to the main menu, theme settings, and select another font (different height) (the file is still playing)
3. Leave the menu, go back to the WPS

The WPS is drawn using the new font, but the progress bar is shown at the old Y-coordinate. "Playing" the WPS file (which is in use) again brings it to the right position again.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 16 February 2009, 08:37 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r20015.
Comment by Alexander Levin (fml2) - Thursday, 12 February 2009, 21:38 GMT
The problem seems to be that the Y-coordinate of the progress bar is fixed during the parsing of the WPS -- even if the %pb tag doesn't contain any parameters. In such case the Y-coordinate should be computed not during the parsing but during the actual rendering IMO. Then the current font size would be taken into account.