Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Uchida - 2009-02-12
Last edited by Llorean - 2009-02-12

FS#9899 - Text viewer plugin: unified patch

I have offered patch files to the following tasks:

 FS#8445  Text viewer crashes when jumping to end of file
 FS#9387  - display error for Asian text
 FS#9546  - UTF-8 BOM “visible” in viewer
 FS#9853  - Text viewer plugin is not displayed to the last line for the large size text file.
 FS#9855  - Text viewer plugin: Title and page number are displayed
 FS#9892  - Text viewer plugin: Patch by which user can set bookmarks freely.
 FS#9893  - Text viewer plugin: Patch that saves preference at each file.
 FS#9898  - Text viewer plugin: Font selection patch

It is a patch file that brings these patches together in one.

   viewer_unified.patch (60.6 KiB)
Closed by  Llorean
2009-02-12 19:43
Reason for closing:  Duplicate
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Please keep patches small and to one task each.

pondlife commented on 2009-02-12 15:16

Hi,

I would think that seperate, smaller patches are more likely to be used than big ones. I know it’s more work to sync them, but think you should should do that and close this.

tri170391 commented on 2009-02-12 15:56

This patch apply fine. But when compile it give a undefined reference to strcmp when linking. Built with vanilla SVN + this patch.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing