Rockbox

Tasklist

FS#9936 - When only config-*.h is changed, apps/features is not updated.

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Sunday, 22 February 2009, 05:16 GMT
Last edited by Björn Stenberg (zagor) - Thursday, 20 August 2009, 22:27 GMT
Task Type Bugs
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When firmware/export/config-*.h is changed, $(BUILDDIR)/apps/features might have to be changed. (eg. svn. 20076)

However, even if config-*.h is updated, features is not updated because it is not checked whether config-*.h was updated in apps.make.
   features.patch (0.7 KiB)
This task depends upon

Closed by  Björn Stenberg (zagor)
Thursday, 20 August 2009, 22:27 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed (with a bit of a kludge, but still) in r22444.
Comment by Boris Gjenero (dreamlayers) - Friday, 10 April 2009, 16:59 GMT
This patch does not work because MODELNAME does not always match the config header name. For example, it works great for the 5G ipod because both are "ipodvideo" but it fails for Gigiabeat F because MODELNAME is gigabeatf but the config header is config-gigabeat.h. This is what happens:
$ make
Generating dependencies
make: *** No rule to make target `/home/Boris/rockbox-svn-trunk/firmware/export/config-gigabeatf.h', needed by `/home/Boris/rockbox-svn-trunk/gbf/apps/features'. Stop.

You can see the mismatches via the following Bash command:
diff <(find firmware/export -name "config-*.h" -printf "%f\n" | sort) <(sed -n "s/^.*modelname=\"\([^\"]*\)\".*$/config-\1.h/p;" tools/configure | sort)

Loading...