- Status Closed
- Percent Complete
- Task Type Bugs
- Category Infrastructure → Build environment
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9936 - When only config-*.h is changed, apps/features is not updated.
When firmware/export/config-*.h is changed, $(BUILDDIR)/apps/features might have to be changed. (eg. svn. 20076)
However, even if config-*.h is updated, features is not updated because it is not checked whether config-*.h was updated in apps.make.
features.patch
(0.7 KiB)
Closed by zagor
2009-08-20 22:27
Reason for closing: Fixed
Additional comments about closing:
2009-08-20 22:27
Reason for closing: Fixed
Additional comments about closing:
Fixed (with a bit of a kludge, but
still) in r22444.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
This patch does not work because MODELNAME does not always match the config header name. For example, it works great for the 5G ipod because both are “ipodvideo” but it fails for Gigiabeat F because MODELNAME is gigabeatf but the config header is config-gigabeat.h. This is what happens:
$ make
Generating dependencies
make: *** No rule to make target `/home/Boris/rockbox-svn-trunk/firmware/export/config-gigabeatf.h’, needed by `/home/Boris/rockbox-svn-trunk/gbf/apps/features’. Stop.
You can see the mismatches via the following Bash command:
diff <(find firmware/export -name “config-*.h” -printf “%f\n” | sort) <(sed -n “s/^.*modelname=\”\([^\”]*\)\”.*$/config-\1.h/p;” tools/configure | sort)