FS#994 - UI changes

Attached to Project: Rockbox
Opened by Joaquim Carvalho (jdcx64) - Saturday, 01 March 2003, 09:11 GMT
Last edited by Joaquim Carvalho (jdcx64) - Tuesday, 01 June 2004, 17:10 GMT
Task Type Patches
Status Closed
Assigned To Daniel Stenberg (bagder)
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


Global keys for easier operation
F1 - sound sliders
F2 - menu
F3 - WPS
ON - Browse

Inverted video cursor line

Better graphics in Tetris

Sound sliders

Faster keyboard scanning

Volume setup "linearized" for very low volume levels
Resolution has not been lost above 60%

No // comments on the code and tried to respect code
This task depends upon

Closed by  Daniel Stenberg (bagder)
Tuesday, 03 June 2003, 14:06 GMT
Reason for closing:  Rejected
Additional comments about closing:  Logged In: YES

This patch is not usable, and I've talked a lot with the
author on email about getting separate patches. Rejecting this.
Comment by Robert E. Hak (adiamas) - Saturday, 01 March 2003, 09:47 GMT

no files attached.
Comment by Anonymous Submitter - Saturday, 01 March 2003, 23:43 GMT

yes no file, that not a good things...
Comment by Lee Pilgrim (diddystar5) - Sunday, 02 March 2003, 00:33 GMT

mesa about to go crazy if mesa get no .diff
Comment by Lee Pilgrim (diddystar5) - Monday, 03 March 2003, 03:30 GMT

I tried it. There are some things i like about it, and some i
don't. The tetris graphical changes i don't like. The f1 =
sound menu i found awarkard since it usually goes to menu
(i changed it in "my version" of rbox). The channel settings
as a slider is really weird. Insted of having sliders as a
seperate menu, i like them kinda like the archos firmware.
Now about the good things. I liked the way you browsed
directories, and where selected stuff is invert, and the new
icons look good. The status bar stands out more, but the
scale is a bit weird for volume. Thanks for the patch.
Comment by Daniel Stenberg (bagder) - Tuesday, 04 March 2003, 15:41 GMT

Thanks a lot for your hard and serious effort.

I cannot accept/apply the full patch, it is just not gonna
incorporate well in Rockbox and I'll tell you why:

1. You assume specific font sizes
2. You do not add new things properly optional
3. You add things I cannot see is subject for doing right now

(and btw, code formatting does not permit tabs in the source)

What would like to ask you to do:

1. Make a separate patch with the "Inverted video cursor
line" feature (optional)
2. Make a separate patch for the "tetris graphics" fix
3. Make a separate patch for the "sound sliders" fix

The faster keyscanning needs more research to see if this
affects performance, especially together with the inverted
cursor line and high bit-rate mp3 songs.

The function-key modifications need more discussions, and I
personally am not convinced of the greatness of your approach.

Again, thanks a lot for your work.
Comment by Daniel Stenberg (bagder) - Tuesday, 03 June 2003, 14:06 GMT

This patch is not usable, and I've talked a lot with the
author on email about getting separate patches. Rejecting this.