- Status Closed
- Percent Complete
- Task Type Patches
- Category
-
Assigned To
bagder - Operating System
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#994 - UI changes
Global keys for easier operation
F1 - sound sliders
F2 - menu
F3 - WPS
ON - Browse
Inverted video cursor line
Better graphics in Tetris
Sound sliders
Faster keyboard scanning
Volume setup “linearized” for very low volume levels
Resolution has not been lost above 60%
No // comments on the code and tried to respect code
formatting
Closed by bagder
2003-06-03 14:06
Reason for closing: Rejected
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2003-06-03 14:06
Reason for closing: Rejected
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Logged In: YES
user_id=1110
This patch is not usable, and I've
talked a lot with the
author on
email about getting separate patches.
Rejecting this.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
no files attached.
yes no file, that not a good things…
mesa about to go crazy if mesa get no .diff
I tried it. There are some things i like about it, and some i
don't. The tetris graphical changes i don't like. The f1 =
sound menu i found awarkard since it usually goes to menu
(i changed it in "my version" of rbox). The channel settings
as a slider is really weird. Insted of having sliders as a
seperate menu, i like them kinda like the archos firmware.
Now about the good things. I liked the way you browsed
directories, and where selected stuff is invert, and the new
icons look good. The status bar stands out more, but the
scale is a bit weird for volume. Thanks for the patch.
Thanks a lot for your hard and serious effort.
I cannot accept/apply the full patch, it is just not gonna
incorporate well in Rockbox and I'll tell you why:
1. You assume specific font sizes
2. You do not add new things properly optional
3. You add things I cannot see is subject for doing right now
(and btw, code formatting does not permit tabs in the source)
What would like to ask you to do:
1. Make a separate patch with the "Inverted video cursor
line" feature (optional)
2. Make a separate patch for the "tetris graphics" fix
3. Make a separate patch for the "sound sliders" fix
The faster keyscanning needs more research to see if this
affects performance, especially together with the inverted
cursor line and high bit-rate mp3 songs.
The function-key modifications need more discussions, and I
personally am not convinced of the greatness of your approach.
Again, thanks a lot for your work.
This patch is not usable, and I've talked a lot with the
author on email about getting separate patches. Rejecting this.