- Status Closed
- Percent Complete
- Task Type Patches
- Category Operating System/Drivers
- Assigned To No-one
- Operating System Another
- Severity Low
- Priority Very Low
- Reported Version Version 3.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Jack Halpin - 2009-02-27
Last edited by MichaelGiacomelli - 2009-04-10
Opened by Jack Halpin - 2009-02-27
Last edited by MichaelGiacomelli - 2009-04-10
FS#9959 - Remove delay code in e200v2 button driver
This patch removes the delay before reading dbop_din and reduces the delay before reading gpio for the buttons on the e200v2. I also added some comments in the read_dbop function to make it easier to follow what is happening. I have not noted any ill effect after removing the dbop delay. The gpio delay is reqired to be at least 1 or the buttons do not work correctly. I have set it at 2 and have noticed no problems after several days of use.
button-e200v2.patch
(4.4 KiB)
Closed by MichaelGiacomelli
2009-04-10 15:20
Reason for closing: Accepted
Additional comments about closing:
2009-04-10 15:20
Reason for closing: Accepted
Additional comments about closing:
Accepted in r20676.
This looks good to me. Would you like me to commit it?
Please do!