• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Unhelpful - 2009-03-08
Last edited by Unhelpful - 2009-04-09

FS#9992 - pictureflow input rework

This rework of pictureflow input uses the the core CONTEXT_TREE in the track list, and a custom action context in the album list except for scrollwheel targets, which use CONTEXT_TREE for both. Tree context rather than standard is used so the tree context’s quit button mapping can be used as a shortcut to exit PF. The standard cancel button will exit if in the album list, or return to album list if viewing a track list. The select button will select an album and change to track list.

The task blocks this from closing
ID Project Summary Priority Severity Assigned To Progress
10104 Rockbox  FS#10104 - PictureFlow manual update for new input work.  Very Low Low
Closed by  Unhelpful
2009-04-09 04:11
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

committed as r20651

Further changes, the base for chaining contexts is CONTEXT_STD. Another context on top of that adds the dedicated quit button, and any other buttons used throughout PF, and a context on top of both of those, used only in the album list, adds left/right scrolling.

Remove c200 dedicated quit button, so it can be used for menu.

Well, I know of the PLA problems, but I’d really try to avoid getting rid of it (since I’m still in love with the general idea of it).
May it’s worth looking at bubbles.rock? It has basically the same problems. In the main screen, you use scrollwheel/left right, and in the game menu you use scrollwheel/up down.

I still think PLA has too much contexts. It should be only _1_ context with 6-7 buttons (4 directions, select. quit, optinally context) + 1 exception context for scrollwheel targets.

One keymap for absolutely everything is not going to work in general, and I don’t think a “generic” keymap works here. The PLA-based pictureflow uses scrollwheel for up/down as well as left/right, but that is not really the main problem. The track list should work as much like core list views as possible, and that can’t happen if the left and right buttons are stolen for scroll actions.

Looking at bubbles.c is not worth at all IMO. Being the first plugin converted to PLA you would expect it to work perfectly - but no, it did not until some ugly exceptions were added. That’s showing nicely how PLA does not work in reality, especially if you need slightly non-standard controls.

One context with 6-7 buttons could work for plugins that only need such a generic control scheme, to me pictureflow just is not one of that type (see Unhelpful’s post for an example)…

I’ve started going over individual keymaps,trying to make sure they’re reasonable in terms of user expectations based on core actions. I’ve implemented some suggestions from discussions with Marianne about the Ondio - core mappings are preserved as much as possible, long off is the dedicated quit button, up is select in album list, with down disabled in album list to avoid confusion.

More keymap updates, again mostly going over the “basic” mapping that adds quit key to the standard context.

Finished going over supported targets, also fixed some errors/inconsistencies for a few targets done earlier.

Changed many targets that were using long POWER/OFF for quit to short POWER/OFF. The exceptions are targets where this is also the menu button, and ones where it is the *only* cancel button.

Since the H10’s left/right buttons are not part of a directional set, and the up/down are presented as a scroller, don’t use custom scroll buttons in H10 album list.


Available keyboard shortcuts


Task Details

Task Editing