Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2009-03-09
Last edited by pondlife - 2009-03-10

FS#9994 - Fix draw sequence on menu exit

As spotted by Bryan Vandyke on  FS#8894 :

“In file menu.c in the do_menu() function about line 623 the function do_setting_from_menu is called. When this function returns true, the original parent menu is redrawn. (The function returns true when the variable in question changes.) Lower in do_menu function, the menucallback with ACTION_EXIT_MENUITEM is called. (which is where the splash screen is displayed) And finally the parent menu is redrawn again.

so what happens is

change setting menu
CHANGE
redraw
callback with splash.

change setting menu
NO CHANGE
callback with splash
redraw”

The attached patch removes the code responsible for this inconsistency. I can’t find any problems resulting, but I suspect there was a reason for having 2 code paths, so please enlighten me!

   menu_draw_fix.patch (1.8 KiB)
Closed by  pondlife
2009-03-10 07:34
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Thanks to Bryan again!

kugel. commented on 2009-03-09 15:20

Good catch. I only spot one possible problem. The parent probably needs to be reinititialized if the setting in question changes the vp, like toggling the statusbar. I’ll look into it.

jdgordon commented on 2009-03-10 03:54

from a quick first glance it looks ok… if kugel is happy to double check im happy with that… dont really have much stamina for rockbox atm :/

kugel. commented on 2009-03-10 04:44

Should be fine, from my tests. This init_menu_lists *should* be deprecated anyway.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing