All Projects

This is an attempt to achieve the goal once discussed in the forums and/or in irc. It should allow to not turn on the backlight on certain key presses. IIRC there is already a patch doing this. But a problem there was that the backlight is handled at the firmware level (as opposed to the app level) and hence it was not possible to take the context into account (whether we’re in the WPS or in a menu or…).

This tries to solve this problem. The approach is to provide a callback to the button code (firmware level) that would tell if the backlight should be turned on. The callback itself has access to the app level information (context).

The solution is not finished yet. TODOs:

1. Implement the backlight oracle (see the TODO mark in action.c)
2. Define the backlight properties for the key maps. It’s not done in this patch so it produces many warnings (unassigned struct member).

I nevetherless put up this patch to discuss the approach. Comments are welcome.

Here is my shot at what has been discussed on IRC a couple of days ago. Since I already provided a patch for reordering of items in the main menu (but it was rejected), I liked the idea because:

1. It’s more general (applies to all menus, not only the main one)
2. Menus are adjusted automatically to each user’s usage pattern
3. Even if not used for automatic reordering, it can be used for gathering statistics about the GUI usage and thus provide information for optimizing the menu structure

This is just the first quick try, but I hope the idea is clear: each menu item gets a unique ID. IDs are generated by macros, so no need to edit many source files; hopefully, there won’t be any name conflicts. If there will the line number (as in PP macro LINE) could somehow be incorporated into the ID. I just couldn’t figure how to do it. With lines incorporated, names become more unique but also more fragile.

Also, each item gets a counter for how many times the item was selected.

Then, before a menu is displayed, its items are reordered so that more frequently used items go to the top.

At shut down, the stats can be dumped to a file, and loaded again at startup.

There could/should also be settings telling:
- whether the stats should be gathered (maybe you’ve achieved your dream configuration want to freeze it?)
- whether the reordering should be made (useful e.g. for blind users)

TODOs:

1. Find a better place for the definition of GATHER_CALL_STATS so that this feature can be cut at compile time
2. Add something to the macros that would register each item’s stats struct in a global array. This array would then be used for dumping/loading
3. Implement dumping/loading the stats (now everything is initialized with zero)
4. Add the appropriate settings

Please don’t put this down immediately after you see “menu reordering.” Just live with the idea some time, and maybe you’ll like it. And I’d be glad if someone would help me with all this.

I’d definitely use it to reorder some items and would then freeze my stats once the desired and frequently used items are on the places where I’d like to find them.

This is a font I created for using in the FM radio screen. I contains only digits, the period and the default character that will be used to display all other letters. Ascent and descent are set to 0 so that there will be no vertical spacing.

Update: I added latin letters so that the font can be included into the font pack.

This simplifies code, we don’t have to analyse whether it’s a .link file etc – each part has its own little task.

Also, two options are introduced:

1. In the link file, you can specify the display name for the entry. It should be separated from the path by the TAB. E.g.

/my/path/<TAB>My favourite songs

2. In the file, you can write

#Display last path segments=N

and then only the last N path segments will be displayed. This is handy if your music is in a deep folder.

Explicit name (with a TAB) has higher priority than N, i.e. if N=2 and you have

/aa/bb/cc/x.mp3<TAB>YYY

then the item will be displayed as YYY and not as bb/cc/x.mp3

I get some strange linker errors. Before I split the plugin into two everything worked OK.

Here is a patch that adds the ‘Startup Screen’ option to the playback menu (General Settings → Playback → Startup Screen). Possible values are:

- File Browser
- FM Radio (only on devices where it’s present)
- Playback (formerly known as ‘Resume on Startup’)
- Recording Screen (only on devices with recording capability, formerly known as ‘Start Rockbox in Recording Screen’)
- Last Active Screen

The options ‘Resume on Startup’ and ‘Start Rockbox in Recording Screen’ have been removed.

Known issues:

1. The ‘Last Active Screen’ feature is not implemented yet, it’s equivalent to ‘File Browser’ for now (see file tree.c) – since I don’t know where is the best place to track the active screen.

2. Version of the settings structure is increased, so save your settings before installing this patch.

3. I’m not completely sure whether the ‘FM Radio’ option is implemented correctly, I used the code for ‘Recording Screen’ as a template.

So it would do no harm if a developer familiar with Rockbox structure would throw a critical look at it!

First shot at nimbus-18 (my favourite shape). All basic glyphs have been designed, so the rest should be trivial. Markun, are you reading this?

This patch allows to change pitch not only by a certain amount of percents but also in halftone steps. Pitch changing mode is toggled by pressing MODE button while in the pitch screen.

Key mapping is only provided for H1xx since I don’t know which buttons are the best candidates for this on other players.

Also a small bug is corrected reg. nudging: if nudging would exceed the allowed range then it’s not executed. But on button release, the “denudging” was always executed – regardless whether the nudging was previously applied.

TODO:
- the active mode should somehow be displayed on the screen (an asterisk?)
- half tone pitching is not very accurate, the error is accumulated. But for simple pupose of transposing a piece it’s OK.

I’m very interested in your opinions about this patch.

This adds the printf format for pointers. Use %p or %P.

Example:

int *p;
printf(”Int value at %p is %d”, p, *p);

Also corrected the code indentation and factored out duplicated code.

Since I like the game but mostly as an exercise in programming RB, I’ve coded up the plugin for reversi game. It should work on all targets with a bitmap display.

As moves are made, they are stored in the game history so that it’s possible to save the track. It should be also possible to choose the playing strategy for each player.

TODOs:

- Really implement the automatic playing strategies (take them from hinversi?)
- Implement loading/saving a game from/to a file
- Implement robot players (provisions are made but the main loop should be adjusted)
- Make nicer GUI - …

Anyone interested?

The contents of the ZIP file should be placed to the ‘plugins’ directory, and the patch should also be applied.

Correctly handle files with long names containing non-latin characters (more precisely: files whose names, when utf8 encoded, require more than 255 bytes). This avoids player freeze when such files are present in the file system.

The patch does the following. When reading a entry for a file with long name, the name is first utf8-decoded into a temporary buffer. Then the check is made whether the content of the buffer would fit into the dir entry. If not, the long name is ignored and the short DOS name (which is OEM encoded) is used instead.

Beware: If this short name contains characters from the upper half of the code page, that name may appear with strange glyphs or empty character in the file browser. This is because Unicode characters 0×80 to 0x9F are control characters. They can’t be displayed.

I have some files with cyrillic characters in the tags. But I don’t like the unifont since it’s too thin for my taste. So I added cyrillic chracters to the my favorite font nimbus-14 (it’s thicker and hence easier to read). And while I was at it I also added some east european characters since they all look very similar. I have not added any chinese/korean/japanese glyphs.

There is another patch for nimbus-14 with cyrillic and chinese glyphs, but it was created automatically from some TrueType font so the symbols don’t look very nice. Here every symbol was “designed carefully.”

The patch is produced not against the SVN but in my local environment, directly from the fonts folder. Sorry for that.

This is a version of nimbus19 with some capitals made one pixel wider so that the gap between the legs of, say, H, has the same width as the legs’ thickness. Please try this and decide whether the font looks better that way (=more readable). If yes, we could provide a nimbus19w version of the font with wider capitals. It could be used on DAPs with large screen width.

The letters changed are: A, B, D, G, H, J, O, P, Q, R, U, V, X. That’s it for now.

If the font doesn’t look nice then this task should be abandoned.

Introduce a new WPS tag (%ms) which indicates whether te study mode is activated.

This patch implements the idea proposed and discussed in http://forums.rockbox.org/index.php?topic=24952.0

It adds a new option of how to create and maintain the list of the recent bookmarks (MRB): one per track. With this option, if a bookmark is added to the MRB, other bookmarks from the same playlist and the same track are not retained.

Comments are welcome.

I think it would be good if we could introduce such option for “normal” bookmark files too, i.e. to store only one bookmark per track in a bookmark list. But this would be matter of a separate patch.

Position cursor to the current setting when browsing fonts, wps, rwps, eq preset, fmr. This can’t be done for themes since the current theme is not saved in the settings.

Here’s a patch for the broken ‘follow playlist’ feature. The bug was reported on irc on Mar 30, 2007, 22:32:29 as follows:

On my H120, I press NAVI while in wps. And the folder the song is in is _not_ shown.

I’ve tested the patch on the sim for H120. It seems to fix the problem.

Here is my take on what has been proposed on irc on Apr 5 2007, about 13:00 (according to the irc log).

This did reduce the size of the binary, at least on my H120.

Here’s the extract from the irc log:

13:04:02 crop I’d reorganise the wps_data struct.
13:04:24 crop 1. make progress_xxx vars unsigned
13:05:15 crop 2. intriduce struct subline with the fields start_token_idx, possibly num_tokens, line_type, and time_mult
13:06:04 crop Introduce struct line with the fields start_subline_idx, possibly num_sublines, subl_expire_time, and curr_subline
13:07:12 crop The idea is that all sublines are stored in one array and the fields point to that array. Now it’s assumed that each line can have up to 12 sublines which is rarely the case I’d argue and this wastes space
13:07:43 crop Tokens are already stored this way.
13:08:07 crop Structuring the data into structures would also make the code more readable IMHO 13:10:09 crop And one more thing: why do we need tokens for NOP and EOL? Why not just store the tokens that belong to the subline? In my proposal, start_subline_idx would say where the subline starts (index in the tokens array). The num_tokens isn’t strictly needed since a subline ends where the next begins. The same idea applies to lines.
13:10:58 crop This would simplify the drawing code since you have clear bounds and don’t have to watch out if we’ve reached EOL. This should be done at parsing time IMHO

This is a fix for the bug reported in  FS#7027 

The comment field in the attached file should be “ÄÖÜäöüß” (German umlauts; the problem also occurs when e.g. cyrillic letters are used). But in “Show ID3 Info” screen it is shown as in the attached image. The font used is nimbus-14, it contains the appropriate glyphs (so it’s because of the bad font).

I don’t know whether this is a problem with ID3 reading or just displaying.

Observed in r14585.

This text should be inserted into “/manual/rockbox_interface/tagcache.tex” before the line “\subsection{\label{ref:databasemenu}The Database Menu}”

Sorry for not creating a proper patch.

Some words about the shortcuts plugin. I have not tried to build it so some corrections might be necessary.

The patch adds the possibilty to move the cursor with shift in the other dimension. For example, if you move the cursor up and it wraps (jumps to the last row), the column is also changed (one to the left). Thus you can reach every calculator button by just keeping pressing up or down or left or right.

As of now, the button combination is only defined for Sansa e200/c200 (scroll wheel back and fwd) and only for moving up/down since that’s what the wheel does in menus and lists.

Also introduced constants for the number od button rows and columns. And renamed ‘global’ variables for the cursor positions. m and n are too short to be a global name IMHO.

The title says it all, I have nothing to add

The number parameter in the %mv tag (volume changing) should be interpreted as seconds. But it’s interpreted as 0.1 secs. I.e. 2.5 will wait 0.25 secs instead of 2.5. The patch fixes that.

Some WPS tags are described with just what the tag produces (e.g. “Current track”), others use the phrasing like “Display the current track.” The patch unifies the descriptions, now we just tell what the tag produces, the words “Display”/”Show” are dropped.

Also, added a reference to the list of the available config settings for the generic WPS setting tag.

The pathc was created against r19371.

The implementation of the force_backlight_on was not correct IMO. If the current setting value is OFF then calling the function wouldn’t have any effect.

I noticed that on sansa e200 simulator the backlight is not simulated. This patch provides a visible cue when the backlight is not on. The image is not very nice, some tweaks might be necessary. But it’s still better than nothing IMO.

This is a fix for the bug reported in  FS#9894 

Since this is the font used in the default theme, I think we should fill it with as many glyphs as we can so that users don’t get confused if they choose a language with glyphs other than latin. Here’s my try to add the cyrillic glyphs.

I imported the 12-Adobe-Helv into fontforge and edited the file. I’ve forgotten how to generate the proper BDF file from it so anybody familiar with fontforge please help.

I just attach the whole file i sfd format (format used by fontforge).

The patch does the following:

1. Reading of the file is now done char by char. This makes it not dangerous if the file is big
2. Code readability is improved via introducing of get_cell
3. Slight speed improvement in calculating the next generation (n[4] is taken from the previous generation)
4. A first step is made in decoupling of the grid size from the LCD size

I've read somewhere that titles should better be typeset in a sans serif font. Chapter titles in the manual are already typeset that way because this is taken care of by the document style. But on the front page (which is constructed 'by hand') they are not. This patch corrects it.

I like the result with the patch better than without.

The current code constructs the question whether the hotkey should be assigned from the confirmation by just appending a quotation mark (i.e. "Set xyz" → "Set xyz?") This doesn't work for all languages.

The patch changes it so that it's better localizable.

Latex has a nice symbol 'times' (looking like an 'x' but nicer). The patch uses it where appropriate. In HTML it can (and should) be displayed as '&times;'.

Experienced with r17749.

I started playback by selecting the first file in a directory (so that the playlist was created ‘on the fly’). All files are mp3’s encoded at 128 …(don’t remember the unit).

There are 18 files in the directory (it’s ‘Chess’ by Andersson & Ulvaeus).

The last track was playing when playback stopped. There were still 1:28 in the track to play.

Player still reacted to some key presses (backlight went on). I tried to shut the player down. The splash ‘Shutting down…’ appeared but the player didn’t shut down.

It seems that this bug only shows up if the playlist is long enough since I didn’t experience it when I started a directory with the third from the end file.

The lower left ‘curve’ should have a corner

Some changes to nimbus-12 and nimbus-14 that make glyphs more consistent within the font

The bug can be reproduced with the build CVS-061118 and a MP3 file with 128kbps and 44100 Hz (created with LAME encoder through CDEx GUI).
Device: Iriver H120.

How to reproduce:

1. Start a song (song A). I used a song of about 3 min length.
2. Wait until it’s come to about 10 secs before the end. You can also use fast forward button to faster get to this point.
3. Wait until it gets to 2 or 1 or 0 secs before the end (I use the remaining duration in WPS). WIth 3 secs before the end, the error does not occur.
4. Press left. This should start the song A from the beginning since it’s still displayed in the WPS.

However, the next song (song B) starts. If the remaining time was 2 secs it goes down to 0. But the WPS still displays the song A. Progress bar and time in the WPS are frozen at the end of the song A (e.g. remaining duration is 0:00). After pressing NAVI (which displays the file browser), the cursor is on the song A. Pressing PLAY (cursor has not been moved) gets back to WPS. There, the song B with correct progress bar and time indicators is displayed.

Here is also the configuration file (exported just before submitting this bug report) – in order to avoid many questions about the settings.

I saw the discussion in IRC. As I’m the last person who touched the pitch screen code…

Also changed the intial pitch screen mode to be ‘semitone’ (it was ‘percent’ before)

More intuitive key mapping for pitch screen (iriver H100 and iriver H300 series).

Now:

NAVI = reset to 100%
PLAY = go back to WPS (as in file browser)
STOP = go back to WPS (as in settings menu)

Remote should work in a similar way.

I have not tested this with remote control.

Adds description of the pitch changing modes to the manual. The change already includes changes of the patch  FS#6394 .

Small clarification about the pitch screen

I’ve followed the discussion about the usage of #if and #ifdef on the IRC. It was noticed that some HAVE_XXX symbols are defined with values. Here is the patch that corrects this. Fortunately, HAVE_XXX were tested only with #ifdef so that only definitions (and not usage) had to be changed. I have not compiled this on all platforms, only on H1xx and Gigabeat.

There is another sort of constants: CONFIG_XXX. They are all defined with values and should be tested with #if CONFIG_XXX == YYY.

Only rockbox’s ‘own’ code was considered, not the third party libs since they should stay easy to merge with their respective master code base.

And while I’m at it, here is the list of all HAVE_XXX symbols (could be placed on a wiki page). Couldn’t/Shouldn’t the HAVE_WMnnnn group be replaced with one CONFIG_XXX?

HAVE_ADJUSTABLE_CPU_FREQ
HAVE_AGC
HAVE_ALARM_MOD
HAVE_ATA_LED_CTRL
HAVE_ATA_POWER_OFF
HAVE_BACKLIGHT_BRIGHTNESS
HAVE_BACKLIGHT_PWM_FADING
HAVE_BACKLIGHT_SET_FADING
HAVE_DAC3550A
HAVE_DIRCACHE
HAVE_DISPLAY_FLIPPED
HAVE_EEPROM
HAVE_EEPROM_SETTINGS
HAVE_EXTENDED_MESSAGING_AND_NAME
HAVE_FAT16SUPPORT
HAVE_FLASHED_ROCKBOX
HAVE_FLASH_DISK
HAVE_FMADC
HAVE_FMRADIO_IN
HAVE_GDB_API HAVE_HEADPHONE_DETECTION
HAVE_HOTSWAP
HAVE_I2C_LOW_FIRST
HAVE_LCD_BITMAP
HAVE_LCD_CHARCELLS
HAVE_LCD_COLOR
HAVE_LCD_CONTRAST
HAVE_LCD_ENABLE
HAVE_LCD_FLIP
HAVE_LCD_INVERT
HAVE_LCD_SLEEP
HAVE_MAS_SIBI_CONTROL
HAVE_MMC
HAVE_MPEG2_5_SAMPR
HAVE_MPEG2_SAMPR
HAVE_MULTIVOLUME
HAVE_ONDIO_ADC
HAVE_ONDIO_I2C
HAVE_PITCHSCREEN
HAVE_PORTRAIT_LCD
HAVE_POWEROFF_ON_PADR
HAVE_POWEROFF_ON_PB5
HAVE_POWEROFF_ON_PBDR
HAVE_POWEROFF_WHILE_CHARGING
HAVE_PP5024_CODEC
HAVE_PRIORITY_SCHEDULING
HAVE_QUICKSCREEN
HAVE_RECORDING
HAVE_REMOTE_LCD
HAVE_REMOTE_LCD_TICKING
HAVE_RTC_RAM
HAVE_SCHEDULER_BOOSTCTRL
HAVE_SPDIF_IN
HAVE_SPDIF_OUT
HAVE_SPDIF_POWER
HAVE_SW_POWEROFF
HAVE_TAGCACHE
HAVE_TC_RAMCACHE
HAVE_TLV320
HAVE_TUNER_PWR_CTRL
HAVE_UDA1380
HAVE_USB_POWER
HAVE_WHEEL_POSITION
HAVE_WM8721
HAVE_WM8731
HAVE_WM8751
HAVE_WM8758
HAVE_WM8975