All Projects

It would be nice if I could jump to a certain folder using a bookmark. As of now, it’s only possible to mark a point in a song. The proposed feature would be handy in the following situation.

My music collection is organised as artist/album/songs (which is quite common) and I often listen to some artists/albums. I’d like to quickly jump to those folders without having to browse and scroll in the file browser. From there, I could quickly select the desired song.

As of now, I’ve just bookmarked a song in the folder of interest and also have activated the “Follow playlist” setting. I then resume the bookmark and continue browsing from the WPS. But this is not as nice as it could be.

A really small ‘const’ clean up

Here is what jdgordon asked for in irc: serach and replace of HAS_BUTTONBAR to HAVE_BUTTONBAR to be in line with other HAVE_xxx symbols.

I hope I haven’t missed anything.

A small patch that IMHO improves readability of the checks. The functionality itself was introduced with r17690.

The title says it all, I have nothing to add

This is an attempt to achieve the goal once discussed in the forums and/or in irc. It should allow to not turn on the backlight on certain key presses. IIRC there is already a patch doing this. But a problem there was that the backlight is handled at the firmware level (as opposed to the app level) and hence it was not possible to take the context into account (whether we’re in the WPS or in a menu or…).

This tries to solve this problem. The approach is to provide a callback to the button code (firmware level) that would tell if the backlight should be turned on. The callback itself has access to the app level information (context).

The solution is not finished yet. TODOs:

1. Implement the backlight oracle (see the TODO mark in action.c)
2. Define the backlight properties for the key maps. It’s not done in this patch so it produces many warnings (unassigned struct member).

I nevetherless put up this patch to discuss the approach. Comments are welcome.

There is a bug in the WPS interpreter. How to reproduce:

Create a simple WPS containing just one of the following tags (standalone, not as a conditional switch): %mm, %mp

As soon as WPS screen is shown, I get segmentation fault. I didn’t try it on the target, only on the sim.

Attached is the correcting patch.

The patch splits the parse_timeout function into a worker one and the functions used for a specific tag thus allowing to define context sensitive logic more locally. Also, the worker function doesn’t need to know where it is called from.

The patch eliminates the last parameter (len) of the macro FILENAME_SETTING thus making it easier to use and at the same time less error prone. Before, the string size had to be written down twice: once in the definition of the setting (in setting.h) and then in the definition of how the setting is stored in the cfg file. Both sizes should match. But since all setting strings are defined as char arrays we can just use sizeof(), no need to explicitly specify the max length.

The max_length member (in struct filename_setting) could probably also be eliminated, but I wanted to make the patch as small as possible.

The number parameter in the %mv tag (volume changing) should be interpreted as seconds. But it’s interpreted as 0.1 secs. I.e. 2.5 will wait 0.25 secs instead of 2.5. The patch fixes that.

no task description

As of build of Apr 01 2006, there is an option (in the ‘recording’ menu) to activate the recording screen on start up (i.e. after the DAP is switched on). It would be useful if it’d also be possible to specify the FM Radio screen as the start up screen. I.e. we’d have the menu entry ‘Initial Screen’ in the ‘General Settings’ menu with three options:

- File Browser
- FM Radio
- Recording Screen

The two latter options should of course appear only on the platforms where they are available. On platforms where the both are not available, the whole menu entry ‘Initial Screen’ wouldn’t appear at all (since it would then have only one option to select). The logic in the order of the options: the first two are ‘play back’ options (→ produce sound, group them together), the third is recording (→ something different).

Setting ‘Show recording screen on startup’ to ‘yes’ would set the new option to ‘FM Radio’. Or, alternatively, the ‘Show recording screen on startup’ option would disappear.

Here is a patch that adds the ‘Startup Screen’ option to the playback menu (General Settings → Playback → Startup Screen). Possible values are:

- File Browser
- FM Radio (only on devices where it’s present)
- Playback (formerly known as ‘Resume on Startup’)
- Recording Screen (only on devices with recording capability, formerly known as ‘Start Rockbox in Recording Screen’)
- Last Active Screen

The options ‘Resume on Startup’ and ‘Start Rockbox in Recording Screen’ have been removed.

Known issues:

1. The ‘Last Active Screen’ feature is not implemented yet, it’s equivalent to ‘File Browser’ for now (see file tree.c) – since I don’t know where is the best place to track the active screen.

2. Version of the settings structure is increased, so save your settings before installing this patch.

3. I’m not completely sure whether the ‘FM Radio’ option is implemented correctly, I used the code for ‘Recording Screen’ as a template.

So it would do no harm if a developer familiar with Rockbox structure would throw a critical look at it!

I’ve followed the discussion about the usage of #if and #ifdef on the IRC. It was noticed that some HAVE_XXX symbols are defined with values. Here is the patch that corrects this. Fortunately, HAVE_XXX were tested only with #ifdef so that only definitions (and not usage) had to be changed. I have not compiled this on all platforms, only on H1xx and Gigabeat.

There is another sort of constants: CONFIG_XXX. They are all defined with values and should be tested with #if CONFIG_XXX == YYY.

Only rockbox’s ‘own’ code was considered, not the third party libs since they should stay easy to merge with their respective master code base.

And while I’m at it, here is the list of all HAVE_XXX symbols (could be placed on a wiki page). Couldn’t/Shouldn’t the HAVE_WMnnnn group be replaced with one CONFIG_XXX?

HAVE_ADJUSTABLE_CPU_FREQ
HAVE_AGC
HAVE_ALARM_MOD
HAVE_ATA_LED_CTRL
HAVE_ATA_POWER_OFF
HAVE_BACKLIGHT_BRIGHTNESS
HAVE_BACKLIGHT_PWM_FADING
HAVE_BACKLIGHT_SET_FADING
HAVE_DAC3550A
HAVE_DIRCACHE
HAVE_DISPLAY_FLIPPED
HAVE_EEPROM
HAVE_EEPROM_SETTINGS
HAVE_EXTENDED_MESSAGING_AND_NAME
HAVE_FAT16SUPPORT
HAVE_FLASHED_ROCKBOX
HAVE_FLASH_DISK
HAVE_FMADC
HAVE_FMRADIO_IN
HAVE_GDB_API HAVE_HEADPHONE_DETECTION
HAVE_HOTSWAP
HAVE_I2C_LOW_FIRST
HAVE_LCD_BITMAP
HAVE_LCD_CHARCELLS
HAVE_LCD_COLOR
HAVE_LCD_CONTRAST
HAVE_LCD_ENABLE
HAVE_LCD_FLIP
HAVE_LCD_INVERT
HAVE_LCD_SLEEP
HAVE_MAS_SIBI_CONTROL
HAVE_MMC
HAVE_MPEG2_5_SAMPR
HAVE_MPEG2_SAMPR
HAVE_MULTIVOLUME
HAVE_ONDIO_ADC
HAVE_ONDIO_I2C
HAVE_PITCHSCREEN
HAVE_PORTRAIT_LCD
HAVE_POWEROFF_ON_PADR
HAVE_POWEROFF_ON_PB5
HAVE_POWEROFF_ON_PBDR
HAVE_POWEROFF_WHILE_CHARGING
HAVE_PP5024_CODEC
HAVE_PRIORITY_SCHEDULING
HAVE_QUICKSCREEN
HAVE_RECORDING
HAVE_REMOTE_LCD
HAVE_REMOTE_LCD_TICKING
HAVE_RTC_RAM
HAVE_SCHEDULER_BOOSTCTRL
HAVE_SPDIF_IN
HAVE_SPDIF_OUT
HAVE_SPDIF_POWER
HAVE_SW_POWEROFF
HAVE_TAGCACHE
HAVE_TC_RAMCACHE
HAVE_TLV320
HAVE_TUNER_PWR_CTRL
HAVE_UDA1380
HAVE_USB_POWER
HAVE_WHEEL_POSITION
HAVE_WM8721
HAVE_WM8731
HAVE_WM8751
HAVE_WM8758
HAVE_WM8975

Correctly handle files with long names containing non-latin characters (more precisely: files whose names, when utf8 encoded, require more than 255 bytes). This avoids player freeze when such files are present in the file system.

The patch does the following. When reading a entry for a file with long name, the name is first utf8-decoded into a temporary buffer. Then the check is made whether the content of the buffer would fit into the dir entry. If not, the long name is ignored and the short DOS name (which is OEM encoded) is used instead.

Beware: If this short name contains characters from the upper half of the code page, that name may appear with strange glyphs or empty character in the file browser. This is because Unicode characters 0×80 to 0x9F are control characters. They can’t be displayed.

This reduced the binary size of rockbox.iriver by ~20 bytes. Not that much but…

In ata.c, the same condition is used to include/exclude some parts of code. This patch conditionally defines a symbol and uses it instead.

The title says it all. It'snot a driver and hence should be moved to another subdir.

And the function is_diacritic should return a bool, not an int.

Save/Load the FM region along with the presets. Preset files are backward compatible, i.e. the new setting doesn’t have to be present.

Note: the region is saved as a number (corresponds to the value of the setting), not as a text (as it’s done in the general settings). This is not good but I don’t know how to reuse the code from the settings.

r19871, Sansa e280 with FM radio

An FM stations file is set. Go to the FM screen. It should be possible to go to the next/previous station with RIGHT/LEFT. But pressing the buttons does no have any effect. The station is not switched.

In some regions, the frequency is changed in 0.1 MHz steps, so that there's no need to display it with two digits after the decimal point. This patch formats the frequency as needed.

I have some files with cyrillic characters in the tags. But I don’t like the unifont since it’s too thin for my taste. So I added cyrillic chracters to the my favorite font nimbus-14 (it’s thicker and hence easier to read). And while I was at it I also added some east european characters since they all look very similar. I have not added any chinese/korean/japanese glyphs.

There is another patch for nimbus-14 with cyrillic and chinese glyphs, but it was created automatically from some TrueType font so the symbols don’t look very nice. Here every symbol was “designed carefully.”

The lower left ‘curve’ should have a corner

First shot at nimbus-18 (my favourite shape). All basic glyphs have been designed, so the rest should be trivial. Markun, are you reading this?

Some changes to nimbus-12 and nimbus-14 that make glyphs more consistent within the font

No functional change, just a correction of two static functions

The patch is produced not against the SVN but in my local environment, directly from the fonts folder. Sorry for that.

This is a version of nimbus19 with some capitals made one pixel wider so that the gap between the legs of, say, H, has the same width as the legs’ thickness. Please try this and decide whether the font looks better that way (=more readable). If yes, we could provide a nimbus19w version of the font with wider capitals. It could be used on DAPs with large screen width.

The letters changed are: A, B, D, G, H, J, O, P, Q, R, U, V, X. That’s it for now.

If the font doesn’t look nice then this task should be abandoned.

The patch adds the comments clarifying the copyright and the license of the font nimbus-19

Since this is the font used in the default theme, I think we should fill it with as many glyphs as we can so that users don’t get confused if they choose a language with glyphs other than latin. Here’s my try to add the cyrillic glyphs.

I imported the 12-Adobe-Helv into fontforge and edited the file. I’ve forgotten how to generate the proper BDF file from it so anybody familiar with fontforge please help.

I just attach the whole file i sfd format (format used by fontforge).

This is a font I created for using in the FM radio screen. I contains only digits, the period and the default character that will be used to display all other letters. Ascent and descent are set to 0 so that there will be no vertical spacing.

Update: I added latin letters so that the font can be included into the font pack.

Since I like the game but mostly as an exercise in programming RB, I’ve coded up the plugin for reversi game. It should work on all targets with a bitmap display.

As moves are made, they are stored in the game history so that it’s possible to save the track. It should be also possible to choose the playing strategy for each player.

TODOs:

- Really implement the automatic playing strategies (take them from hinversi?)
- Implement loading/saving a game from/to a file
- Implement robot players (provisions are made but the main loop should be adjusted)
- Make nicer GUI - …

Anyone interested?

The contents of the ZIP file should be placed to the ‘plugins’ directory, and the patch should also be applied.

The comment field in the attached file should be “ÄÖÜäöüß” (German umlauts; the problem also occurs when e.g. cyrillic letters are used). But in “Show ID3 Info” screen it is shown as in the attached image. The font used is nimbus-14, it contains the appropriate glyphs (so it’s because of the bad font).

I don’t know whether this is a problem with ID3 reading or just displaying.

Observed in r14585.

The patch does just what the title says (and nothing else). I think the new name more clearly states what the field means. I hope I catched all occurences.

In a separate patch I'll probably rename the field "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet".

This patch renames "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet". It also pulls the field "present" out of the "embedded_cuesheet" structure and renames it to "has_embedded_cuesheet".

This patch, together with  FS#12470 , unify how cuesheet and albumart data are represented in mp3entry.

I saw the discussion in IRC. As I’m the last person who touched the pitch screen code…

Also changed the intial pitch screen mode to be ‘semitone’ (it was ‘percent’ before)

Some corrections to the Russian translation

Another small correction of the Russian translation

Another small correction of the Russian translation

Add some hotkey related phrases and correct some other cases

I think (and the internet confirms that) that the correct spelling is sepArate, not sepErate. The patch corrects this.

There are other places with 'seperate', but they should be fixed in another patch (or patches).

In the e200 v1 simulator, if I position the cursor on a long name in the file browser, it does not scroll. This happens in r20829. With r20828, everything works as it should. Hence r20829 must have introduced a bug.

I have not tried whether the same happens on target.

When the bidirectional scrolling for a line of text is active, there is a delay before the text starts to scroll in the opposite direction. But when the text only scrolls forward (because the bidir scrolling limit has not been reached) there is no delay between the scroll rounds.

The patch introduces a delay also for the forward scrolling case. This makes the scrolling behaviour more consistent and also makes it easier to catch the start of the text.

Adds description of the pitch changing modes to the manual. The change already includes changes of the patch  FS#6394 .

Small clarification about the pitch screen

The key for toggling mode in the pitch screen (little steps / semitone) is not defined for e200 manual.