All Projects

no task description

The new variable name more clearly conveys what the setting is for. IMO.

The manual say how to change the menu but not how to restore it.

This happens on my Sansa e280v1 with r31634-120108

I wanted to record something using the inbuilt microphone. The menu "RB Info" tells me there is space on the internal card:

132MB/7.45GB

When I start the recording, and then stop it while the WRS screen shows about 50KB, I get the message "Disk is full. Press PREV to continue."

After that, there is no recorded file. (The file should be created in the root directory of the internal card; WRS shows "Filename: /./R_MIC…")

But there IS space on the card! I could copy a file (via USB) of size 100 KB without problems.

So I think something is fishy in the recording code.

Is this somehow related to  FS#7721 ?

The setting is set via a customized call in the UI, hence we do not need the formatter in the setting itself. Also, the min/max/step values from the setting declaration are ignored – just as an info.

This patch renames "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet". It also pulls the field "present" out of the "embedded_cuesheet" structure and renames it to "has_embedded_cuesheet".

This patch, together with  FS#12470 , unify how cuesheet and albumart data are represented in mp3entry.

The patch does just what the title says (and nothing else). I think the new name more clearly states what the field means. I hope I catched all occurences.

In a separate patch I'll probably rename the field "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet".

When the bidirectional scrolling for a line of text is active, there is a delay before the text starts to scroll in the opposite direction. But when the text only scrolls forward (because the bidir scrolling limit has not been reached) there is no delay between the scroll rounds.

The patch introduces a delay also for the forward scrolling case. This makes the scrolling behaviour more consistent and also makes it easier to catch the start of the text.

I use sim build for iriver H120, r28922

When I run the disktidy plugin, change the settings (what files to clean) and quit the plugin (without performing the clean itself), I get the error message that the config file could not be saved.

I tried to investigate the problem, some findings are at http://www.rockbox.org/irc/log-20101228#22:07:08

But I could not get through the forest of all the defines for the file function.

See also http://www.rockbox.org/irc/log-20101229#11:41:04

Current version: 28881.

The disktidy plugin seems not not to delete directories specified by a pattern. I.e. if you have the directories "tf1" and "tf2", and "tf*/" is specified in the config file, then tf1 and tf2 should be deleted, but they are not.

The attached patch tries to fix that.

I think (and the internet confirms that) that the correct spelling is sepArate, not sepErate. The patch corrects this.

There are other places with 'seperate', but they should be fixed in another patch (or patches).

This patch implements the idea proposed and discussed in http://forums.rockbox.org/index.php?topic=24952.0

It adds a new option of how to create and maintain the list of the recent bookmarks (MRB): one per track. With this option, if a bookmark is added to the MRB, other bookmarks from the same playlist and the same track are not retained.

Comments are welcome.

I think it would be good if we could introduce such option for “normal” bookmark files too, i.e. to store only one bookmark per track in a bookmark list. But this would be matter of a separate patch.

Opening apostrophes should be typeset as `

Latex has a nice symbol 'times' (looking like an 'x' but nicer). The patch uses it where appropriate. In HTML it can (and should) be displayed as '×'.

This probably belongs to the section about defining viewports, i.e. to the files manual/advanced_topics/viewports/XYZ-vp-syntax.tex. As of now, it says that only the system and one user selected font are possible.

In some regions, the frequency is changed in 0.1 MHz steps, so that there's no need to display it with two digits after the decimal point. This patch formats the frequency as needed.

This is a font I created for using in the FM radio screen. I contains only digits, the period and the default character that will be used to display all other letters. Ascent and descent are set to 0 so that there will be no vertical spacing.

Update: I added latin letters so that the font can be included into the font pack.

The tag was introduced in r25826 – again without even trying to update the manual!

A quote from  FS#11233 :
— In current manual for Clip (20100430), it lists Play as being the button to return to the WPS if there's a valid current playlist (Play/Pause is actually used to move upward in lists). Pixelma informed me in the forums that the correct button combination is Home + Select. This does work on my Clip v1.
—

If I understand the code correctly, the correct buttons should indeed be Home+Select. The attached patch corrects the manual.

Add some hotkey related phrases and correct some other cases

The hotkey items have the lang_id's although the menus already have them. The patch eliminates the redundancy. This should also slightly reduce the bin size, but the main purpose of the patch is to get rid of the redundancy (the lang_id in the hotkey item has to match the lang_id in the menu).

The hotkey items must point to MENUITEM_FUNCTION now, which is the case for all hotkeyable items now.

The names use for hotkey related stuff in onplay.c (HOT_WPS etc.) are not best IMO. This patch makes them more associaed with hotkey and also introduces some comments.

Somemenus are described as "Hotkeyable" but it's not instantly clear what that means. This patch adds a reference to the explanation.

The title says it all. It'snot a driver and hence should be moved to another subdir.

And the function is_diacritic should return a bool, not an int.

The current code constructs the question whether the hotkey should be assigned from the confirmation by just appending a quotation mark (i.e. "Set xyz" → "Set xyz?") This doesn't work for all languages.

The patch changes it so that it's better localizable.

Seen with r25455 on Sansa e200 v1

Display the hotkey assignments (menu Settings→General Settings→Hotkey→View Hotkey Settings). The items in the displayed list do not scroll so that if the function name is long it’s not possible to read all of it.

The hotkey feature (introduced in r25414) is not described in the manual

Seen in r25280.

The descriptions says:

Track is ending. An optional number gives how many seconds the tag remains true for after the start of the track.

But shouldn't it read: "An optional number gives how many seconds before the end of the track the tag becomes true"?

Since the button maps are not really floating objects, there is no need to typeset them inside a table environment. Captions (in the rear cases where they are used) could be set with the help of 'caption2' package, but I left them in a 'table' for now.

The tag was introduced in r20753

See the subject. The tags were introduced in r24917.

The subject tells it all. The tag itself was introduced in r23207 on Fri Oct 16 21:14:33 2009 CEST. Wasn’t it a rule that with a feature also the manual should be updated?

This is just a reminder: with r24615 two new audio file formats are supported. They should be mentioned in the manual, appendix A.2 ("Supported audio formats")

When I start the simulator for sansa e200, the screen goes black after some seconds of inactivity. When I then press buttons, the screen does not turn on, i.e. it remains completely black.

Seen with r24075. I suspect that the bug was introduced in r24042 and its companions.

I've seen some comments about the reason and a possible fix in IRC but have not tried them out.

This patch changes everything to the "do" as was agreed in IRC.

In some places in the manual, keys are described as "do this and that", in other places it is "does this and that." The patch unifies this making all to "Does."

Only core rockbox is adjusted, not plugins.

I've read somewhere that titles should better be typeset in a sans serif font. Chapter titles in the manual are already typeset that way because this is taken care of by the document style. But on the front page (which is constructed 'by hand') they are not. This patch corrects it.

I like the result with the patch better than without.

File manual/main_menu/fmradio.tex, r23817: "At this point, you will switched". "be" after "will" is missing.

Again: I have no SVN or IRC access, hence the bug report.

File manual/main_menu/fmradio.tex, line with "The FM radio has the ability \opt{recording}{to record and } to"

I think, the space between the "and" and the closing brace should be removed as it causes too much space in the PDF. I.e. it should read "\opt{recording}{to record and} to"

I don't have SVN access now, so I thought I'd rather file this bug report.

Seen in r23799.

I'm on a fresh computer and still not able to commit patches myself. So please Mr. Someone, commit this for me.

Just so that it doesn't get forgotten: the keymap table for the WRS in the manual is screwed at some places. This is because there are some additional '&' and '\\' that cause wrong table rows to appear.

I might have a look at this later but would also be glad if someone else could do this.

The wrong places are in the file manual/main_menu/recording_screen.tex, seen in r32414.

I don't have access to the SVN now. So I just downloaded the tex file, edited it and made a diff (with a help of a text editor). This aspect of Rockbox isn't well described in the manual IMHO.

Please review it and maybe prepare a proper patch and maybe commit it.

The lack of comments makes the developer's work hard. Let's make it a little bit easier!

Since OFFON is a special case of BOOL, we should define the former via the latter.

As of r22405, the setting "Scrollbar position" has the following options (in this order): Right, Left. IMO it would be more intuitive to have them in the order "Left, Right".

This makes necessary that the meaning of the "scrollbar pos" setting is changed. Now it is "false=right, true=left". This patch changes it to the opposite, i.e. "false=left, true=right".

(The setting is modeled with a boolean value, and such values are normally displayed in the order "false, true" in the menu.)

If someone has set the scrollbar position other than the default then the scrollbar will change its position after applying this patch.

(Edit: attach the actual patch)