All Projects

Experienced with r17749.

I started playback by selecting the first file in a directory (so that the playlist was created ‘on the fly’). All files are mp3’s encoded at 128 …(don’t remember the unit).

There are 18 files in the directory (it’s ‘Chess’ by Andersson & Ulvaeus).

The last track was playing when playback stopped. There were still 1:28 in the track to play.

Player still reacted to some key presses (backlight went on). I tried to shut the player down. The splash ‘Shutting down…’ appeared but the player didn’t shut down.

It seems that this bug only shows up if the playlist is long enough since I didn’t experience it when I started a directory with the third from the end file.

Correctly handle files with long names containing non-latin characters (more precisely: files whose names, when utf8 encoded, require more than 255 bytes). This avoids player freeze when such files are present in the file system.

The patch does the following. When reading a entry for a file with long name, the name is first utf8-decoded into a temporary buffer. Then the check is made whether the content of the buffer would fit into the dir entry. If not, the long name is ignored and the short DOS name (which is OEM encoded) is used instead.

Beware: If this short name contains characters from the upper half of the code page, that name may appear with strange glyphs or empty character in the file browser. This is because Unicode characters 0×80 to 0x9F are control characters. They can’t be displayed.

Observed with the SVN revision 12728

How to reproduce:

1. Call up the main menu and go to ‘System’. At the top, the menu title ‘System’ is displayed with the user selected font
2. Position the cursor on ‘Version’ 3. Press RIGHT (RB logo with the version number at the bottom is displayed) and after one second press LEFT.

Now I’m back in the ‘System’ menu (as expected) but the title ‘System’ is displayed with the system (and not user selected) font

I have some files with cyrillic characters in the tags. But I don’t like the unifont since it’s too thin for my taste. So I added cyrillic chracters to the my favorite font nimbus-14 (it’s thicker and hence easier to read). And while I was at it I also added some east european characters since they all look very similar. I have not added any chinese/korean/japanese glyphs.

There is another patch for nimbus-14 with cyrillic and chinese glyphs, but it was created automatically from some TrueType font so the symbols don’t look very nice. Here every symbol was “designed carefully.”

As of build of Apr 01 2006, there is an option (in the ‘recording’ menu) to activate the recording screen on start up (i.e. after the DAP is switched on). It would be useful if it’d also be possible to specify the FM Radio screen as the start up screen. I.e. we’d have the menu entry ‘Initial Screen’ in the ‘General Settings’ menu with three options:

- File Browser
- FM Radio
- Recording Screen

The two latter options should of course appear only on the platforms where they are available. On platforms where the both are not available, the whole menu entry ‘Initial Screen’ wouldn’t appear at all (since it would then have only one option to select). The logic in the order of the options: the first two are ‘play back’ options (→ produce sound, group them together), the third is recording (→ something different).

Setting ‘Show recording screen on startup’ to ‘yes’ would set the new option to ‘FM Radio’. Or, alternatively, the ‘Show recording screen on startup’ option would disappear.

Here is a patch that adds the ‘Startup Screen’ option to the playback menu (General Settings → Playback → Startup Screen). Possible values are:

- File Browser
- FM Radio (only on devices where it’s present)
- Playback (formerly known as ‘Resume on Startup’)
- Recording Screen (only on devices with recording capability, formerly known as ‘Start Rockbox in Recording Screen’)
- Last Active Screen

The options ‘Resume on Startup’ and ‘Start Rockbox in Recording Screen’ have been removed.

Known issues:

1. The ‘Last Active Screen’ feature is not implemented yet, it’s equivalent to ‘File Browser’ for now (see file tree.c) – since I don’t know where is the best place to track the active screen.

2. Version of the settings structure is increased, so save your settings before installing this patch.

3. I’m not completely sure whether the ‘FM Radio’ option is implemented correctly, I used the code for ‘Recording Screen’ as a template.

So it would do no harm if a developer familiar with Rockbox structure would throw a critical look at it!

The lower left ‘curve’ should have a corner

Model: iriver H120, Build: 2006-09-01 17:59, Default settings

Installed the build (settings were reset since the settings version was changed)
Changed file view to ‘All’ Went to ./rockbox/fmpresets, chose a preset file → radio is activated
Changed to preset mode
Pressed NAVI → station list displays
* Pressed DOWN → * the cursor doesn’t move *
Pressed DOWN once more → cursor moves
Left station list screen
Pressed NAVI → station list displays
* Pressed UP → * the cursor doesn’t move *
Pressed UP once more → cursor moves

First shot at nimbus-18 (my favourite shape). All basic glyphs have been designed, so the rest should be trivial. Markun, are you reading this?

Some changes to nimbus-12 and nimbus-14 that make glyphs more consistent within the font

Position cursor to the current setting when browsing fonts, wps, rwps, eq preset, fmr. This can’t be done for themes since the current theme is not saved in the settings.

This patch allows to change pitch not only by a certain amount of percents but also in halftone steps. Pitch changing mode is toggled by pressing MODE button while in the pitch screen.

Key mapping is only provided for H1xx since I don’t know which buttons are the best candidates for this on other players.

Also a small bug is corrected reg. nudging: if nudging would exceed the allowed range then it’s not executed. But on button release, the “denudging” was always executed – regardless whether the nudging was previously applied.

TODO:
- the active mode should somehow be displayed on the screen (an asterisk?)
- half tone pitching is not very accurate, the error is accumulated. But for simple pupose of transposing a piece it’s OK.

I’m very interested in your opinions about this patch.

The bug can be reproduced with the build CVS-061118 and a MP3 file with 128kbps and 44100 Hz (created with LAME encoder through CDEx GUI).
Device: Iriver H120.

How to reproduce:

1. Start a song (song A). I used a song of about 3 min length.
2. Wait until it’s come to about 10 secs before the end. You can also use fast forward button to faster get to this point.
3. Wait until it gets to 2 or 1 or 0 secs before the end (I use the remaining duration in WPS). WIth 3 secs before the end, the error does not occur.
4. Press left. This should start the song A from the beginning since it’s still displayed in the WPS.

However, the next song (song B) starts. If the remaining time was 2 secs it goes down to 0. But the WPS still displays the song A. Progress bar and time in the WPS are frozen at the end of the song A (e.g. remaining duration is 0:00). After pressing NAVI (which displays the file browser), the cursor is on the song A. Pressing PLAY (cursor has not been moved) gets back to WPS. There, the song B with correct progress bar and time indicators is displayed.

Here is also the configuration file (exported just before submitting this bug report) – in order to avoid many questions about the settings.

I saw the discussion in IRC. As I’m the last person who touched the pitch screen code…

Also changed the intial pitch screen mode to be ‘semitone’ (it was ‘percent’ before)

To reproduce the bug, do the following:

1. Switch the DAP on
2. Start music playback (MP3 file in my case)
3. Wait about 5 sec
4. Goto WPS context menu (on H120: hold NAVI pressed), and then to the pitch screen
5. Change pitch value to 105%
6. Go back to the WPS
7. Jump to the start of the song (on H120: press LEFT)

Expected: playback starts from the beginning of the song with the new pitch

Observed: no sound, progress bar and elapsed time are advanced at approx. double speed. If you again go to the pitch screen and change the pitch value, the sound immediately appears again.

More intuitive key mapping for pitch screen (iriver H100 and iriver H300 series).

Now:

NAVI = reset to 100%
PLAY = go back to WPS (as in file browser)
STOP = go back to WPS (as in settings menu)

Remote should work in a similar way.

I have not tested this with remote control.

Adds description of the pitch changing modes to the manual. The change already includes changes of the patch  FS#6394 .

Small clarification about the pitch screen

Following would be nice: you press a special key and get the list of all possible keys (in the current context) with their meaning. This would help if you don’t know exactly what you can do in a screen.

Since I like the game but mostly as an exercise in programming RB, I’ve coded up the plugin for reversi game. It should work on all targets with a bitmap display.

As moves are made, they are stored in the game history so that it’s possible to save the track. It should be also possible to choose the playing strategy for each player.

TODOs:

- Really implement the automatic playing strategies (take them from hinversi?)
- Implement loading/saving a game from/to a file
- Implement robot players (provisions are made but the main loop should be adjusted)
- Make nicer GUI - …

Anyone interested?

The contents of the ZIP file should be placed to the ‘plugins’ directory, and the patch should also be applied.

I’ve followed the discussion about the usage of #if and #ifdef on the IRC. It was noticed that some HAVE_XXX symbols are defined with values. Here is the patch that corrects this. Fortunately, HAVE_XXX were tested only with #ifdef so that only definitions (and not usage) had to be changed. I have not compiled this on all platforms, only on H1xx and Gigabeat.

There is another sort of constants: CONFIG_XXX. They are all defined with values and should be tested with #if CONFIG_XXX == YYY.

Only rockbox’s ‘own’ code was considered, not the third party libs since they should stay easy to merge with their respective master code base.

And while I’m at it, here is the list of all HAVE_XXX symbols (could be placed on a wiki page). Couldn’t/Shouldn’t the HAVE_WMnnnn group be replaced with one CONFIG_XXX?

HAVE_ADJUSTABLE_CPU_FREQ
HAVE_AGC
HAVE_ALARM_MOD
HAVE_ATA_LED_CTRL
HAVE_ATA_POWER_OFF
HAVE_BACKLIGHT_BRIGHTNESS
HAVE_BACKLIGHT_PWM_FADING
HAVE_BACKLIGHT_SET_FADING
HAVE_DAC3550A
HAVE_DIRCACHE
HAVE_DISPLAY_FLIPPED
HAVE_EEPROM
HAVE_EEPROM_SETTINGS
HAVE_EXTENDED_MESSAGING_AND_NAME
HAVE_FAT16SUPPORT
HAVE_FLASHED_ROCKBOX
HAVE_FLASH_DISK
HAVE_FMADC
HAVE_FMRADIO_IN
HAVE_GDB_API HAVE_HEADPHONE_DETECTION
HAVE_HOTSWAP
HAVE_I2C_LOW_FIRST
HAVE_LCD_BITMAP
HAVE_LCD_CHARCELLS
HAVE_LCD_COLOR
HAVE_LCD_CONTRAST
HAVE_LCD_ENABLE
HAVE_LCD_FLIP
HAVE_LCD_INVERT
HAVE_LCD_SLEEP
HAVE_MAS_SIBI_CONTROL
HAVE_MMC
HAVE_MPEG2_5_SAMPR
HAVE_MPEG2_SAMPR
HAVE_MULTIVOLUME
HAVE_ONDIO_ADC
HAVE_ONDIO_I2C
HAVE_PITCHSCREEN
HAVE_PORTRAIT_LCD
HAVE_POWEROFF_ON_PADR
HAVE_POWEROFF_ON_PB5
HAVE_POWEROFF_ON_PBDR
HAVE_POWEROFF_WHILE_CHARGING
HAVE_PP5024_CODEC
HAVE_PRIORITY_SCHEDULING
HAVE_QUICKSCREEN
HAVE_RECORDING
HAVE_REMOTE_LCD
HAVE_REMOTE_LCD_TICKING
HAVE_RTC_RAM
HAVE_SCHEDULER_BOOSTCTRL
HAVE_SPDIF_IN
HAVE_SPDIF_OUT
HAVE_SPDIF_POWER
HAVE_SW_POWEROFF
HAVE_TAGCACHE
HAVE_TC_RAMCACHE
HAVE_TLV320
HAVE_TUNER_PWR_CTRL
HAVE_UDA1380
HAVE_USB_POWER
HAVE_WHEEL_POSITION
HAVE_WM8721
HAVE_WM8731
HAVE_WM8751
HAVE_WM8758
HAVE_WM8975

Brings the FM related settings together so that they build a group. No functional changes.

Save/Load the FM region along with the presets. Preset files are backward compatible, i.e. the new setting doesn’t have to be present.

Note: the region is saved as a number (corresponds to the value of the setting), not as a text (as it’s done in the general settings). This is not good but I don’t know how to reuse the code from the settings.

This reduced the binary size of rockbox.iriver by ~20 bytes. Not that much but…

Implement the "anti karaoke" mode. In karaoke mode, only the differences between left and right channels are retained, the "common" part of the left and right channels is cut off.

What I'd like to have is a mode where only the voice "in the center" is left and voices that are present only in the left or only in the right channel are cut off (or significantly lowered).

Here is make take to make the order of the entries in the main menu customizable. Only the order may be changed, key shortcuts etc. is not changed.

The solution is a bit clumsy (if not ugly). To change the order of the entries, create a text file named “main_menu.mnu” in the folder “/.rockbox”. In this file, place the following lines in the order you’d like to have the entries in the main menu:

bookmarks
files
database
now playing
settings
recording
fm radio
playlists
plugins
system
shutdown

The line with “fm radio” should only be present on DAPs with FM radio. The line with “shutdown” should only be present on DAPs with char cells.

An example for H120:

bookmarks
files
now playing
fm radio
settings
playlists
recording
database
plugins
system

If something goes wrong (file does not exist, unknown entries, bad number of lines etc.) the root menu is not changed.

This feature can be propagated to other menues, but I think it would be an overkill. But the main menu is used often and hence should be optimized as much as possible to the taste of every single user.

If this will be propagated to other menues, we could create a field in the menu structure to hold the “id” of the menu entry.

Comments are welcome.

How to reproduce:

1. Go to the FM radio screen
2. Bring up the main menu
3. In the main menu, select ‘Now playing’ or ‘Resume playback’

Expected: FM screen is shown
Observed: DAP tries to start MP3 playback

Here is a patch to fix the bug from  FS#6799 . One should really leave everything in a state it was before we got in…

…which will result in a shorter battery life

How to reproduce:

1. Call up the main menu
2. Select ‘System’ 3. Select ‘Version’ 4. While the logo is displayed, press STOP

After that, the LCD backlight won’t go off even if it’s configured to do so in the settings.

I think, the reason is that in credits.c, lines 49-50, the backlight timeout is not set back if the plugin is stopped before the name show has started.

The patch is really simple.

Here’s a patch for the broken ‘follow playlist’ feature. The bug was reported on irc on Mar 30, 2007, 22:32:29 as follows:

On my H120, I press NAVI while in wps. And the folder the song is in is _not_ shown.

I’ve tested the patch on the sim for H120. It seems to fix the problem.

Here is my take on what has been proposed on irc on Apr 5 2007, about 13:00 (according to the irc log).

This did reduce the size of the binary, at least on my H120.

Here’s the extract from the irc log:

13:04:02 crop I’d reorganise the wps_data struct.
13:04:24 crop 1. make progress_xxx vars unsigned
13:05:15 crop 2. intriduce struct subline with the fields start_token_idx, possibly num_tokens, line_type, and time_mult
13:06:04 crop Introduce struct line with the fields start_subline_idx, possibly num_sublines, subl_expire_time, and curr_subline
13:07:12 crop The idea is that all sublines are stored in one array and the fields point to that array. Now it’s assumed that each line can have up to 12 sublines which is rarely the case I’d argue and this wastes space
13:07:43 crop Tokens are already stored this way.
13:08:07 crop Structuring the data into structures would also make the code more readable IMHO 13:10:09 crop And one more thing: why do we need tokens for NOP and EOL? Why not just store the tokens that belong to the subline? In my proposal, start_subline_idx would say where the subline starts (index in the tokens array). The num_tokens isn’t strictly needed since a subline ends where the next begins. The same idea applies to lines.
13:10:58 crop This would simplify the drawing code since you have clear bounds and don’t have to watch out if we’ve reached EOL. This should be done at parsing time IMHO

As of now, %cP produces “am/pm” and %cp produces “AM/PM” (lowercase produces uppercase and vice versa). I think this should be changed.

Another proposal: let’s make the RTC tags “atomic”, i.e. let’s write “%ca %cb” instead of “%ca bc”. The parsing will become simpler as well as handling as well as they will be more like other tags (each %-tag produces a piece of information and stands on its own). There are no other tags that require a terminating char.

Here is the patch for the more intuitive definition of am/pm (first part of the request  FS#6994 ). With this patch applied, P will produce AM/PM and p will produce am/pm.

For the committers: should this patch be committed please don’t forget to update the wiki and the manual.

This is the patch for the second part of the request  FS#6994 . It changes the RTC tags so that each tag produces a piece of text.

Before this patch: %cd m yc
After this patch: %cd %cm %cy

I.e. there are now many %cX tags. The terminating c in the RTC tags is not needed anymore.

This introduces incompatibility with the existing RTC tags. WPS’s included with RB are updated in this patch.

The parser has become more elegant IMO. The code in gwps-common.c has become uglier at one place since the structure cur_time is filled not directly at the place where it’s used.

No functional change, just a correction of two static functions

If there is no current playlist (e.g. a dynamically created playlist has been played to the end), selecting "View current playlist" in the menu does nothing. Either the menu entry shouldn't be present then or (better IMHO) a splash should be displayed stating that there's no playlist to view.

Observed with the build r13130

This adds the printf format for pointers. Use %p or %P.

Example:

int *p;
printf(”Int value at %p is %d”, p, *p);

Also corrected the code indentation and factored out duplicated code.

The patch is produced not against the SVN but in my local environment, directly from the fonts folder. Sorry for that.

This is a fix for the bug reported in  FS#7027 

This has been spotted by crop but JdGordon tried and everything worked. I’ve analyzed the code and now think that wps_parser should be corrected (patch is attached).

It works because, when the file is read (in wps_data_load), a ‘\\n’ is appended to every line. This acts as a guard. But nevertheless, the code in wps_parse should not rely on this (and doesn’t, judging by the code).

Also make a loop more readable (this might increase the binary size by a couple of bytes though).

As of now, file name extensions are shown (or not) based on the option “Show files” (All/Supported/etc.) This patch introduces an explicit setting for this.

I read about this in irc logs and liked the idea. The patch is really simple. It can be included without any side effects. But if the RB developers are not excited about this feature I wouldn’t insist that it MUST be included.

It would be nice if I could jump to a certain folder using a bookmark. As of now, it’s only possible to mark a point in a song. The proposed feature would be handy in the following situation.

My music collection is organised as artist/album/songs (which is quite common) and I often listen to some artists/albums. I’d like to quickly jump to those folders without having to browse and scroll in the file browser. From there, I could quickly select the desired song.

As of now, I’ve just bookmarked a song in the folder of interest and also have activated the “Follow playlist” setting. I then resume the bookmark and continue browsing from the WPS. But this is not as nice as it could be.

This simplifies code, we don’t have to analyse whether it’s a .link file etc – each part has its own little task.

Also, two options are introduced:

1. In the link file, you can specify the display name for the entry. It should be separated from the path by the TAB. E.g.

/my/path/<TAB>My favourite songs

2. In the file, you can write

#Display last path segments=N

and then only the last N path segments will be displayed. This is handy if your music is in a deep folder.

Explicit name (with a TAB) has higher priority than N, i.e. if N=2 and you have

/aa/bb/cc/x.mp3<TAB>YYY

then the item will be displayed as YYY and not as bb/cc/x.mp3

I get some strange linker errors. Before I split the plugin into two everything worked OK.

The key for toggling mode in the pitch screen (little steps / semitone) is not defined for e200 manual.

The comment field in the attached file should be “ÄÖÜäöüß” (German umlauts; the problem also occurs when e.g. cyrillic letters are used). But in “Show ID3 Info” screen it is shown as in the attached image. The font used is nimbus-14, it contains the appropriate glyphs (so it’s because of the bad font).

I don’t know whether this is a problem with ID3 reading or just displaying.

Observed in r14585.

This allows to exit the pitch screen (and return to the WPS) via pressing the “Up” button aka “Play”. This is in the line with the principle that pressing Play should take you to the WPS when possible.

Here is my shot at what has been discussed on IRC a couple of days ago. Since I already provided a patch for reordering of items in the main menu (but it was rejected), I liked the idea because:

1. It’s more general (applies to all menus, not only the main one)
2. Menus are adjusted automatically to each user’s usage pattern
3. Even if not used for automatic reordering, it can be used for gathering statistics about the GUI usage and thus provide information for optimizing the menu structure

This is just the first quick try, but I hope the idea is clear: each menu item gets a unique ID. IDs are generated by macros, so no need to edit many source files; hopefully, there won’t be any name conflicts. If there will the line number (as in PP macro LINE) could somehow be incorporated into the ID. I just couldn’t figure how to do it. With lines incorporated, names become more unique but also more fragile.

Also, each item gets a counter for how many times the item was selected.

Then, before a menu is displayed, its items are reordered so that more frequently used items go to the top.

At shut down, the stats can be dumped to a file, and loaded again at startup.

There could/should also be settings telling:
- whether the stats should be gathered (maybe you’ve achieved your dream configuration want to freeze it?)
- whether the reordering should be made (useful e.g. for blind users)

TODOs:

1. Find a better place for the definition of GATHER_CALL_STATS so that this feature can be cut at compile time
2. Add something to the macros that would register each item’s stats struct in a global array. This array would then be used for dumping/loading
3. Implement dumping/loading the stats (now everything is initialized with zero)
4. Add the appropriate settings

Please don’t put this down immediately after you see “menu reordering.” Just live with the idea some time, and maybe you’ll like it. And I’d be glad if someone would help me with all this.

I’d definitely use it to reorder some items and would then freeze my stats once the desired and frequently used items are on the places where I’d like to find them.

1. Open file for writing with ‘creat’ (how did it work without this flag?)
2. Remove unneeded define