All Projects

The bug can be reproduced with the build CVS-061118 and a MP3 file with 128kbps and 44100 Hz (created with LAME encoder through CDEx GUI).
Device: Iriver H120.

How to reproduce:

1. Start a song (song A). I used a song of about 3 min length.
2. Wait until it’s come to about 10 secs before the end. You can also use fast forward button to faster get to this point.
3. Wait until it gets to 2 or 1 or 0 secs before the end (I use the remaining duration in WPS). WIth 3 secs before the end, the error does not occur.
4. Press left. This should start the song A from the beginning since it’s still displayed in the WPS.

However, the next song (song B) starts. If the remaining time was 2 secs it goes down to 0. But the WPS still displays the song A. Progress bar and time in the WPS are frozen at the end of the song A (e.g. remaining duration is 0:00). After pressing NAVI (which displays the file browser), the cursor is on the song A. Pressing PLAY (cursor has not been moved) gets back to WPS. There, the song B with correct progress bar and time indicators is displayed.

Here is also the configuration file (exported just before submitting this bug report) – in order to avoid many questions about the settings.

File manual/main_menu/fmradio.tex, line with "The FM radio has the ability \opt{recording}{to record and } to"

I think, the space between the "and" and the closing brace should be removed as it causes too much space in the PDF. I.e. it should read "\opt{recording}{to record and} to"

I don't have SVN access now, so I thought I'd rather file this bug report.

Seen in r23799.

Just so that it doesn't get forgotten: the keymap table for the WRS in the manual is screwed at some places. This is because there are some additional '&' and '\\' that cause wrong table rows to appear.

I might have a look at this later but would also be glad if someone else could do this.

The wrong places are in the file manual/main_menu/recording_screen.tex, seen in r32414.

Observed with the SVN revision 12728

How to reproduce:

1. Call up the main menu and go to ‘System’. At the top, the menu title ‘System’ is displayed with the user selected font
2. Position the cursor on ‘Version’ 3. Press RIGHT (RB logo with the version number at the bottom is displayed) and after one second press LEFT.

Now I’m back in the ‘System’ menu (as expected) but the title ‘System’ is displayed with the system (and not user selected) font

Seen in r25280.

The descriptions says:

Track is ending. An optional number gives how many seconds the tag remains true for after the start of the track.

But shouldn't it read: "An optional number gives how many seconds before the end of the track the tag becomes true"?

See the subject. The tags were introduced in r24917.

Introduce a new WPS tag (%ms) which indicates whether te study mode is activated.

The tag was introduced in r20753

The subject tells it all. The tag itself was introduced in r23207 on Fri Oct 16 21:14:33 2009 CEST. Wasn’t it a rule that with a feature also the manual should be updated?

In some places in the manual, keys are described as "do this and that", in other places it is "does this and that." The patch unifies this making all to "Does."

Only core rockbox is adjusted, not plugins.

This patch changes everything to the "do" as was agreed in IRC.

Latex has a nice symbol 'times' (looking like an 'x' but nicer). The patch uses it where appropriate. In HTML it can (and should) be displayed as '×'.

I'm on a fresh computer and still not able to commit patches myself. So please Mr. Someone, commit this for me.

No functional change, just a correction of two static functions

Add some hotkey related phrases and correct some other cases

Manual, Appendix A.1: For some formats, “Rockbox does X and Y” is used, for other “Do X and Y”. The patch unifies that to “Do X and Y”.

Some WPS tags are described with just what the tag produces (e.g. “Current track”), others use the phrasing like “Display the current track.” The patch unifies the descriptions, now we just tell what the tag produces, the words “Display”/”Show” are dropped.

Also, added a reference to the list of the available config settings for the generic WPS setting tag.

The pathc was created against r19371.

File manual/main_menu/fmradio.tex, r23817: "At this point, you will switched". "be" after "will" is missing.

Again: I have no SVN or IRC access, hence the bug report.

Seen with r25455 on Sansa e200 v1

Display the hotkey assignments (menu Settings→General Settings→Hotkey→View Hotkey Settings). The items in the displayed list do not scroll so that if the function name is long it’s not possible to read all of it.

The hotkey feature (introduced in r25414) is not described in the manual

The tag was introduced in r25826 – again without even trying to update the manual!

I hope the summary line tells the whole story. Thanks to linuxstb for implementing this feature.

Sansa e280 with FM tuner, r19871

My settings are:
- status bar: no
- the WPS used is very simple, it does contain the %we tag to switch the status bar on

But the status bar is not shown in the WPS

Here is the WPS I use:
%we

%ac%s%?ia<%ia|%d2>
%ac%s%?it<%it|%fn>

%al%pc%ac%pp/%pe%ar-%pr
%pb

%ac%s%?It<%It|%Fn>

Here is a patch that adds the ‘Startup Screen’ option to the playback menu (General Settings → Playback → Startup Screen). Possible values are:

- File Browser
- FM Radio (only on devices where it’s present)
- Playback (formerly known as ‘Resume on Startup’)
- Recording Screen (only on devices with recording capability, formerly known as ‘Start Rockbox in Recording Screen’)
- Last Active Screen

The options ‘Resume on Startup’ and ‘Start Rockbox in Recording Screen’ have been removed.

Known issues:

1. The ‘Last Active Screen’ feature is not implemented yet, it’s equivalent to ‘File Browser’ for now (see file tree.c) – since I don’t know where is the best place to track the active screen.

2. Version of the settings structure is increased, so save your settings before installing this patch.

3. I’m not completely sure whether the ‘FM Radio’ option is implemented correctly, I used the code for ‘Recording Screen’ as a template.

So it would do no harm if a developer familiar with Rockbox structure would throw a critical look at it!

This simplifies code, we don’t have to analyse whether it’s a .link file etc – each part has its own little task.

Also, two options are introduced:

1. In the link file, you can specify the display name for the entry. It should be separated from the path by the TAB. E.g.

/my/path/<TAB>My favourite songs

2. In the file, you can write

#Display last path segments=N

and then only the last N path segments will be displayed. This is handy if your music is in a deep folder.

Explicit name (with a TAB) has higher priority than N, i.e. if N=2 and you have

/aa/bb/cc/x.mp3<TAB>YYY

then the item will be displayed as YYY and not as bb/cc/x.mp3

I get some strange linker errors. Before I split the plugin into two everything worked OK.

To reproduce the bug, do the following:

1. Switch the DAP on
2. Start music playback (MP3 file in my case)
3. Wait about 5 sec
4. Goto WPS context menu (on H120: hold NAVI pressed), and then to the pitch screen
5. Change pitch value to 105%
6. Go back to the WPS
7. Jump to the start of the song (on H120: press LEFT)

Expected: playback starts from the beginning of the song with the new pitch

Observed: no sound, progress bar and elapsed time are advanced at approx. double speed. If you again go to the pitch screen and change the pitch value, the sound immediately appears again.

Some corrections to the Russian translation

Some changes to nimbus-12 and nimbus-14 that make glyphs more consistent within the font

A couple od commas are lacking. The patch adds them.

This makes saving and restoring game state a little bit prettier (IMHO)

A really small ‘const’ clean up

The patch eliminates the last parameter (len) of the macro FILENAME_SETTING thus making it easier to use and at the same time less error prone. Before, the string size had to be written down twice: once in the definition of the setting (in setting.h) and then in the definition of how the setting is stored in the cfg file. Both sizes should match. But since all setting strings are defined as char arrays we can just use sizeof(), no need to explicitly specify the max length.

The max_length member (in struct filename_setting) could probably also be eliminated, but I wanted to make the patch as small as possible.

1. Open file for writing with ‘creat’ (how did it work without this flag?)
2. Remove unneeded define

This reduced the binary size of rockbox.iriver by ~20 bytes. Not that much but…

Save/Load the FM region along with the presets. Preset files are backward compatible, i.e. the new setting doesn’t have to be present.

Note: the region is saved as a number (corresponds to the value of the setting), not as a text (as it’s done in the general settings). This is not good but I don’t know how to reuse the code from the settings.

The title says it all, I have nothing to add

How to reproduce:

1. Go to the FM radio screen
2. Bring up the main menu
3. In the main menu, select ‘Now playing’ or ‘Resume playback’

Expected: FM screen is shown
Observed: DAP tries to start MP3 playback

In ata.c, the same condition is used to include/exclude some parts of code. This patch conditionally defines a symbol and uses it instead.

Here is my take on what has been proposed on irc on Apr 5 2007, about 13:00 (according to the irc log).

This did reduce the size of the binary, at least on my H120.

Here’s the extract from the irc log:

13:04:02 crop I’d reorganise the wps_data struct.
13:04:24 crop 1. make progress_xxx vars unsigned
13:05:15 crop 2. intriduce struct subline with the fields start_token_idx, possibly num_tokens, line_type, and time_mult
13:06:04 crop Introduce struct line with the fields start_subline_idx, possibly num_sublines, subl_expire_time, and curr_subline
13:07:12 crop The idea is that all sublines are stored in one array and the fields point to that array. Now it’s assumed that each line can have up to 12 sublines which is rarely the case I’d argue and this wastes space
13:07:43 crop Tokens are already stored this way.
13:08:07 crop Structuring the data into structures would also make the code more readable IMHO 13:10:09 crop And one more thing: why do we need tokens for NOP and EOL? Why not just store the tokens that belong to the subline? In my proposal, start_subline_idx would say where the subline starts (index in the tokens array). The num_tokens isn’t strictly needed since a subline ends where the next begins. The same idea applies to lines.
13:10:58 crop This would simplify the drawing code since you have clear bounds and don’t have to watch out if we’ve reached EOL. This should be done at parsing time IMHO

The new variable name more clearly conveys what the setting is for. IMO.

This patch renames "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet". It also pulls the field "present" out of the "embedded_cuesheet" structure and renames it to "has_embedded_cuesheet".

This patch, together with  FS#12470 , unify how cuesheet and albumart data are represented in mp3entry.

The patch does just what the title says (and nothing else). I think the new name more clearly states what the field means. I hope I catched all occurences.

In a separate patch I'll probably rename the field "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet".

The function is not used anymore.

The hotkey items have the lang_id's although the menus already have them. The patch eliminates the redundancy. This should also slightly reduce the bin size, but the main purpose of the patch is to get rid of the redundancy (the lang_id in the hotkey item has to match the lang_id in the menu).

The hotkey items must point to MENUITEM_FUNCTION now, which is the case for all hotkeyable items now.

When saving sound/recording/theme/eq settings from the menu, the proposed .cfg file name (which the user can edit) is always “config”, followed by a number. This patch makes the default names dependent on what’s being saved, giving e.g. “sound00.cfg” when saving sound settings and “theme00.cfg” when saving theme settings.