All Projects

The title says it all…

When saving sound/recording/theme/eq settings from the menu, the proposed .cfg file name (which the user can edit) is always “config”, followed by a number. This patch makes the default names dependent on what’s being saved, giving e.g. “sound00.cfg” when saving sound settings and “theme00.cfg” when saving theme settings.

As of now (r21544), the get_time function does return the real time for non-RTC simulators. The patch makes the behaviour more similar to real targets, i.e. Jan 1, 1970, 00:00:00 is always returned.

Also, some comments were added to better understand the #ifdef hell.

This patch adds a new replaygain type “off” and eliminates the menu setting “Enable replaygain”. I hope I got it right

Set the following settings:

‘Show icons’ in the theme settings to “No” ‘Show icons’ in the playlist viewer settings to “Yes”

Under this circumstances, I’d expect the marker of the current song in the playlist to be shown. The same for the marker of the moved song (while moving a song in the playlist). But the markers are not shown.

Tested with r21166 (not the latest today, but I think there were no code changes in this area)

In the e200 v1 simulator, if I position the cursor on a long name in the file browser, it does not scroll. This happens in r20829. With r20828, everything works as it should. Hence r20829 must have introduced a bug.

I have not tried whether the same happens on target.

The patch does the following:

1. Reading of the file is now done char by char. This makes it not dangerous if the file is big
2. Code readability is improved via introducing of get_cell
3. Slight speed improvement in calculating the next generation (n[4] is taken from the previous generation)
4. A first step is made in decoupling of the grid size from the LCD size

Manual, Appendix A.1: For some formats, “Rockbox does X and Y” is used, for other “Do X and Y”. The patch unifies that to “Do X and Y”.

The recently introduced “natural sorting” function places (for example) cyrillic characters before latin. The usual strcmp does it the other way. For files without digits in the name both functions should give the same result.

The difference seem to be caused by the usage of char for internal work. Changing that to int makes everything straight.

Since this is the font used in the default theme, I think we should fill it with as many glyphs as we can so that users don’t get confused if they choose a language with glyphs other than latin. Here’s my try to add the cyrillic glyphs.

I imported the 12-Adobe-Helv into fontforge and edited the file. I’ve forgotten how to generate the proper BDF file from it so anybody familiar with fontforge please help.

I just attach the whole file i sfd format (format used by fontforge).

The patch avoid multiple use of the same condition in the code. Instead, a symbol with meaningful name is introduced and used. This avoid code duplication and improves code readability.

As of now, the clock plugin, in binary mode, draws “0” as a filled and “1” as hollow circle. This is counter intuitive IMO. Hence I flipped the bitmaps vertically. Now 0 is hollow and 1 is filled.

The patch capitalizes the words in “Date/time format” menu entries. Note that setting entries are not touched so that they are backward compatible.

This patch initializes the character’s bounding box with the font’s bounding box when the parsing of the character begins. It can then be overridden with the char’s BBX clause. This makes sense because

1. the font BBX is the default for all characters
2. negative values are valid values for bbx and bby and hence can’t be used for setting them to invalid values (the intention in the old code)

This is a fix for the bug reported in  FS#9894 

The problem occurs with r19974, at least in the simulators for e200 and h120.

I use the following WPS code which can be used with many fonts:

%we

%ac%s%?ia<%ia|%d2>
%ac%s%?it<%it|%fn>

%al%pc%ac%pp/%pe%ar-%pr
%pb

%ac%s%?It<%It|%Fn>

Now, how to reproduce:
1. Start playing a file
2. Go to the main menu, theme settings, and select another font (different height) (the file is still playing)
3. Leave the menu, go back to the WPS

The WPS is drawn using the new font, but the progress bar is shown at the old Y-coordinate. “Playing” the WPS file (which is in use) again brings it to the right position again.

I noticed that on sansa e200 simulator the backlight is not simulated. This patch provides a visible cue when the backlight is not on. The image is not very nice, some tweaks might be necessary. But it’s still better than nothing IMO.

The implementation of the force_backlight_on was not correct IMO. If the current setting value is OFF then calling the function wouldn’t have any effect.

This patch lets the compiler to issue a compile error when the lamp plugin is built for a player without the backlight feature.

Without this patch, the whole file is #ifdef’ed out so that there will be no plugin entry point. The patch makes the compile process fail with a describing error message.

r19933: the lamp plugin can only be left via shutdown (long press of POWER), at least on my Sansa e200. All other buttons are ignored.

BTW: there is the patch FS#8934 that implements switching the lamp on and off. Why isn’t it committed?

The function is not used anymore.

JdGordon committed not the last version of the patch. The return type is int, not char.

The description of the tags is not very clear. One could e.g. understand that they can work as a switch for conditionals. This patch uses the “active” verbs instead of passive.

r19871, Sansa e280 with FM radio

An FM stations file is set. Go to the FM screen. It should be possible to go to the next/previous station with RIGHT/LEFT. But pressing the buttons does no have any effect. The station is not switched.

Sansa e280 with FM tuner, r19871

My settings are:
- status bar: no
- the WPS used is very simple, it does contain the %we tag to switch the status bar on

But the status bar is not shown in the WPS

Here is the WPS I use:
%we

%ac%s%?ia<%ia|%d2>
%ac%s%?it<%it|%fn>

%al%pc%ac%pp/%pe%ar-%pr
%pb

%ac%s%?It<%It|%Fn>

Sansa e280 with FM tuner, r19871

My settings are:
- status bar: no
- FM stations file is selected
- start screen: File Browser

How to reproduce:
1. switch the player on
2. bring up the main menu and select FM radio

At the top of the screen there is the rest of the previous screen.

There is a similar bug report:  FS#9817 

Apply the patch and see what it does. It’s simpler than to describe it here fully

…before the final ‘and’

I’m not a native English speaker but I still think that “device a way” is not correct. The patch changes this to “advise a way.”

Some WPS tags are described with just what the tag produces (e.g. “Current track”), others use the phrasing like “Display the current track.” The patch unifies the descriptions, now we just tell what the tag produces, the words “Display”/”Show” are dropped.

Also, added a reference to the list of the available config settings for the generic WPS setting tag.

The pathc was created against r19371.

The number parameter in the %mv tag (volume changing) should be interpreted as seconds. But it’s interpreted as 0.1 secs. I.e. 2.5 will wait 0.25 secs instead of 2.5. The patch fixes that.

The patch lets the user confirm if the plugin is started on a directory (which may take quite long)

This makes saving and restoring game state a little bit prettier (IMHO)

The patch eliminates the last parameter (len) of the macro FILENAME_SETTING thus making it easier to use and at the same time less error prone. Before, the string size had to be written down twice: once in the definition of the setting (in setting.h) and then in the definition of how the setting is stored in the cfg file. Both sizes should match. But since all setting strings are defined as char arrays we can just use sizeof(), no need to explicitly specify the max length.

The max_length member (in struct filename_setting) could probably also be eliminated, but I wanted to make the patch as small as possible.

The patch documents the %mv tag in the manual

The patch splits the parse_timeout function into a worker one and the functions used for a specific tag thus allowing to define context sensitive logic more locally. Also, the worker function doesn’t need to know where it is called from.

In ata.c, the same condition is used to include/exclude some parts of code. This patch conditionally defines a symbol and uses it instead.

One more comma in the German translation for RBUtil

A couple od commas are lacking. The patch adds them.

There is a bug in the WPS interpreter. How to reproduce:

Create a simple WPS containing just one of the following tags (standalone, not as a conditional switch): %mm, %mp

As soon as WPS screen is shown, I get segmentation fault. I didn’t try it on the target, only on the sim.

Attached is the correcting patch.

The patch adds the comments clarifying the copyright and the license of the font nimbus-19

Another small correction of the Russian translation

This is an attempt to achieve the goal once discussed in the forums and/or in irc. It should allow to not turn on the backlight on certain key presses. IIRC there is already a patch doing this. But a problem there was that the backlight is handled at the firmware level (as opposed to the app level) and hence it was not possible to take the context into account (whether we’re in the WPS or in a menu or…).

This tries to solve this problem. The approach is to provide a callback to the button code (firmware level) that would tell if the backlight should be turned on. The callback itself has access to the app level information (context).

The solution is not finished yet. TODOs:

1. Implement the backlight oracle (see the TODO mark in action.c)
2. Define the backlight properties for the key maps. It’s not done in this patch so it produces many warnings (unassigned struct member).

I nevetherless put up this patch to discuss the approach. Comments are welcome.

Another small correction of the Russian translation