All Projects

Adds description of the pitch changing modes to the manual. The change already includes changes of the patch  FS#6394 .

More intuitive key mapping for pitch screen (iriver H100 and iriver H300 series).

Now:

NAVI = reset to 100%
PLAY = go back to WPS (as in file browser)
STOP = go back to WPS (as in settings menu)

Remote should work in a similar way.

I have not tested this with remote control.

To reproduce the bug, do the following:

1. Switch the DAP on
2. Start music playback (MP3 file in my case)
3. Wait about 5 sec
4. Goto WPS context menu (on H120: hold NAVI pressed), and then to the pitch screen
5. Change pitch value to 105%
6. Go back to the WPS
7. Jump to the start of the song (on H120: press LEFT)

Expected: playback starts from the beginning of the song with the new pitch

Observed: no sound, progress bar and elapsed time are advanced at approx. double speed. If you again go to the pitch screen and change the pitch value, the sound immediately appears again.

I saw the discussion in IRC. As I’m the last person who touched the pitch screen code…

Also changed the intial pitch screen mode to be ‘semitone’ (it was ‘percent’ before)

The bug can be reproduced with the build CVS-061118 and a MP3 file with 128kbps and 44100 Hz (created with LAME encoder through CDEx GUI).
Device: Iriver H120.

How to reproduce:

1. Start a song (song A). I used a song of about 3 min length.
2. Wait until it’s come to about 10 secs before the end. You can also use fast forward button to faster get to this point.
3. Wait until it gets to 2 or 1 or 0 secs before the end (I use the remaining duration in WPS). WIth 3 secs before the end, the error does not occur.
4. Press left. This should start the song A from the beginning since it’s still displayed in the WPS.

However, the next song (song B) starts. If the remaining time was 2 secs it goes down to 0. But the WPS still displays the song A. Progress bar and time in the WPS are frozen at the end of the song A (e.g. remaining duration is 0:00). After pressing NAVI (which displays the file browser), the cursor is on the song A. Pressing PLAY (cursor has not been moved) gets back to WPS. There, the song B with correct progress bar and time indicators is displayed.

Here is also the configuration file (exported just before submitting this bug report) – in order to avoid many questions about the settings.

This patch allows to change pitch not only by a certain amount of percents but also in halftone steps. Pitch changing mode is toggled by pressing MODE button while in the pitch screen.

Key mapping is only provided for H1xx since I don’t know which buttons are the best candidates for this on other players.

Also a small bug is corrected reg. nudging: if nudging would exceed the allowed range then it’s not executed. But on button release, the “denudging” was always executed – regardless whether the nudging was previously applied.

TODO:
- the active mode should somehow be displayed on the screen (an asterisk?)
- half tone pitching is not very accurate, the error is accumulated. But for simple pupose of transposing a piece it’s OK.

I’m very interested in your opinions about this patch.

Position cursor to the current setting when browsing fonts, wps, rwps, eq preset, fmr. This can’t be done for themes since the current theme is not saved in the settings.

Some changes to nimbus-12 and nimbus-14 that make glyphs more consistent within the font

First shot at nimbus-18 (my favourite shape). All basic glyphs have been designed, so the rest should be trivial. Markun, are you reading this?

Model: iriver H120, Build: 2006-09-01 17:59, Default settings

Installed the build (settings were reset since the settings version was changed)
Changed file view to ‘All’ Went to ./rockbox/fmpresets, chose a preset file → radio is activated
Changed to preset mode
Pressed NAVI → station list displays
* Pressed DOWN → * the cursor doesn’t move *
Pressed DOWN once more → cursor moves
Left station list screen
Pressed NAVI → station list displays
* Pressed UP → * the cursor doesn’t move *
Pressed UP once more → cursor moves

The lower left ‘curve’ should have a corner

Correctly handle files with long names containing non-latin characters (more precisely: files whose names, when utf8 encoded, require more than 255 bytes). This avoids player freeze when such files are present in the file system.

The patch does the following. When reading a entry for a file with long name, the name is first utf8-decoded into a temporary buffer. Then the check is made whether the content of the buffer would fit into the dir entry. If not, the long name is ignored and the short DOS name (which is OEM encoded) is used instead.

Beware: If this short name contains characters from the upper half of the code page, that name may appear with strange glyphs or empty character in the file browser. This is because Unicode characters 0×80 to 0x9F are control characters. They can’t be displayed.

Here is a patch that adds the ‘Startup Screen’ option to the playback menu (General Settings → Playback → Startup Screen). Possible values are:

- File Browser
- FM Radio (only on devices where it’s present)
- Playback (formerly known as ‘Resume on Startup’)
- Recording Screen (only on devices with recording capability, formerly known as ‘Start Rockbox in Recording Screen’)
- Last Active Screen

The options ‘Resume on Startup’ and ‘Start Rockbox in Recording Screen’ have been removed.

Known issues:

1. The ‘Last Active Screen’ feature is not implemented yet, it’s equivalent to ‘File Browser’ for now (see file tree.c) – since I don’t know where is the best place to track the active screen.

2. Version of the settings structure is increased, so save your settings before installing this patch.

3. I’m not completely sure whether the ‘FM Radio’ option is implemented correctly, I used the code for ‘Recording Screen’ as a template.

So it would do no harm if a developer familiar with Rockbox structure would throw a critical look at it!

As of build of Apr 01 2006, there is an option (in the ‘recording’ menu) to activate the recording screen on start up (i.e. after the DAP is switched on). It would be useful if it’d also be possible to specify the FM Radio screen as the start up screen. I.e. we’d have the menu entry ‘Initial Screen’ in the ‘General Settings’ menu with three options:

- File Browser
- FM Radio
- Recording Screen

The two latter options should of course appear only on the platforms where they are available. On platforms where the both are not available, the whole menu entry ‘Initial Screen’ wouldn’t appear at all (since it would then have only one option to select). The logic in the order of the options: the first two are ‘play back’ options (→ produce sound, group them together), the third is recording (→ something different).

Setting ‘Show recording screen on startup’ to ‘yes’ would set the new option to ‘FM Radio’. Or, alternatively, the ‘Show recording screen on startup’ option would disappear.

I have some files with cyrillic characters in the tags. But I don’t like the unifont since it’s too thin for my taste. So I added cyrillic chracters to the my favorite font nimbus-14 (it’s thicker and hence easier to read). And while I was at it I also added some east european characters since they all look very similar. I have not added any chinese/korean/japanese glyphs.

There is another patch for nimbus-14 with cyrillic and chinese glyphs, but it was created automatically from some TrueType font so the symbols don’t look very nice. Here every symbol was “designed carefully.”