All Projects

IDProjectTask TypeCategorySeveritySummaryOpened
 10194 RockboxPatchesGamesLow Remove usage of pluginlib actions from bubbles plugin 2009-05-0921 Task Description

According to an earlier discussion on IRC (a long time ago), pluginlib actions are not desirable and should be removed. This patch removes pluginlib actions from the bubbles plugin.

What this patch does:
1. Remove pluginlib actions and replace them with button codes.
2. Remove #define’s made unneccessary by r19253.
3. Some minor cleanups here and there.

 9491 RockboxPatchesFont/charsetLow Some characters in 18-Adobe-Helvetica are spaced quite  ...2008-10-151 Task Description

Some characters in 18-Adobe-Helvetica have weird spacing. So far,

k: it is drawn without a space to the left
m: it is drawn with an extra space to the left

The patch attached fixes these two characters.

 9473 RockboxPatchesUser InterfaceLow Reorganize Playback Settings menu 2008-10-1031 Task Description

This patch reorganizes the Playback Settings menu. The problem is that this menu looks very disorganized – this is an attempt at organizing the menu.

This is not a final patch and I welcome any and all suggestions to improve it.

P.S. I will modify the manual accordingly after the menu order is settled.

Old

Shuffle
Repeat
Play Selected First
Fast-Forward/Rewind
Anti-Skip Buffer
Fade on Stop/Pause
Party Mode
Crossfade
Replaygain
Beep
SPDIF
Auto-Change Directory
Last.fm Log
Cuesheet Support
Pause on Headphone Unplug
Skip Length

New

Shuffle
Repeat
Fade on Stop/Pause
Play Selected First
Auto-Change Directory
Party Mode
Anti-Skip Buffer
Crossfade
Replaygain
Fast-Forward/Rewind
Beep Volume
Skip Length
Pause on Headphone Unplug
SPDIF
Cuesheet Support
Last.fm log

 9472 RockboxPatchesUser InterfaceLow Move "Playback Settings" out of "General Settings" 2008-10-101 Task Description

This patch moves “Playback Settings” out of “General Settings” into the “Settings” menu. Then it reorders the menu items a bit so that the settings menu looks like this:

General Settings
Sound Settings
Playback Settings
Recording Settings
Theme Settings
Manage Settings

 9463 RockboxPatchesLanguageLow Some Simplified Chinese fixes 2008-10-0643 Task Description

I’ve modified/fixed some strings in the chinese-simp.lang file. The strings are modified to:
1. make it easier to understand, as a Chinese user
2. use more common phrases, as opposed to some awkward ones originally used in the translation

 9461 RockboxPatchesUser InterfaceLow Display current directory rather than "Files" for root  ...2008-10-0681 Task Description

This patch changes the behaviour of the file browser if “Show Path” is set to “Current Directory Only”.

Old behaviour: For the root directory, show “Files”.
New behaviour: For the root directory, show “/”.

9456RockboxPatchesPlaylistsLowRemove Repeat:Shuffle option and always reshuffle when ...2008-10-0555 Task Description

This patch removes the Repeat:Shuffle setting, and always reshuffles the playlist when Shuffle is set to yes and Repeat is set to All.

The rationale behind this is that a user would rarely want to shuffle the playlist the first time only and always repeat the same sequence afterwards. Rather, one would either play the playlist in order and repeat in the same order, or shuffle the playlist first and always reshuffle.

Setting combinations affected:
- Shuffle:Yes && Repeat:All

before: shuffle the playlist but repeats the same sequence
after: shuffle the playlist and reshuffles when the end is reached

- Shuffle:Yes && Repeat:Shuffle

before: shuffle the playlist and reshuffles when the end is reached
after: this combination is replaced by Shuffle:Yes && Repeat:All

- Shuffle:No && Repeat:Shuffle

before: reshuffle when the end is reached
after: rarely used combination, not available anymore

All other combinations are not affected.

The patch contains some comment fixes and some code simplification as well. We also have to handle a special case in the patch.

 9232 RockboxPatchesPluginsLow Genericized help viewer for plugins 2008-08-0267 Task Description

This is a generic help viewer for plugins, with basic scrolling and word wrapping features.

With this help viewer, I hope to make all plugins (or at least games) to get a main menu and move all the help messages into a submenu. This will make Rockbox plugins look much more professional rather than just some random code thrown together.

Attached is a very early draft; it lacks:
1. scrollbar support
2. continuous scrolling
3. background display
4. etc

Please try the patch with the test plugin (also attached) and comment. In particular, I need some suggestions on how to best implement the word wrapping feature – currently it’s very simplistic.

 9191 RockboxPatchesGamesLow Revamp of maze plugin code (apps/plugins/maze.c) 2008-07-1363 Task Description

I’ve revamped the code in apps/plugins/maze.c while fixing the bug in  FS#9184 . Here are the main changes:

1. Whitespace changes.

2. Code cleanups.

3. Comments for non-trivial code blocks.

4. Make all functions static.

5. Reorder and regroup several functions.

6. Use border-detection macros instead of border property bits, use 8 bit entities for each cell.

7. Only solve the maze the first time maze_solve() is called.

8. Add and use maze.show_path to control whether the solution is displayed.

9. Modify the path bits only in maze_solve().

10. Modify the algorithm in maze_solve() to make it clearer.

11. Link together the solution instead of showing discrete blocks.

12. Rewrite maze_pick_random_neighbour_cell_with_walls(), and remove coord_stack_count() and coord_stack_get().

13. Rewrite the coordinate stack operations, use arrays of x and y coordinates.

14. Remove bug workaround with rb→yield() when quitting.

This fixes  FS#9184 , so if this patch is accepted, that task can also be closed.

9112RockboxPatchesBuild environmentLowAutomatically set correct cross compiler path based on ...2008-06-2353 Task Description

This is an attempt to automate the setting of $PATH in tools/rockboxdev.sh, tools/configure and the generated Makefile.

The directory prefix of the cross compilers is stored in ~/.config/rockbox.org/RockboxCompilerPrefix. As the default path (in tools/rockboxdev.sh) is /usr/local, if that file is empty, then $PATH won’t be modified. Otherwise, the value stored inside that file will be read, the target platform type appended, and lastly /bin appended. The resulting string will be appended to $PATH.

This patch doesn’t break existing configuration. But it’s most probably incomplete, so please provide feedback on which files need to be modified as well.

9093RockboxBugsDatabaseLowDatabase initialization hangs if there's no music file ...2008-06-1683 Task Description

The database hangs when doing initialization if there is no music file on the player.

How to reproduce:
1. Install Rockbox.
2. Put some music files onto the device.
3. Initialize database.
4. Reboot.
5. Remove all music files from the player.
6. Initialize database.

9060RockboxPatchesFont/charsetLowWenQuanYi Bitmap Song fonts2008-05-3114 Task Description

This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2]. This font is similar to the WenQuanYi Unibit font (FS#9059) and focuses mostly on ASCII and CJK, but I’m also posting this font for inclusion because this one has different point sizes, like for example the nimbus, Sazanami and ProFont fonts already included in Rockbox. With the different point sizes, especially lower point sizes, this font is great for small screens such as my iPod Nano.

I’m attaching some screenshots of this font under various point sizes and weights. I’ve also taken screenshots with the simulator to show how it would look like in Rockbox.

Additionally, this font is available from the original website at [3]. There is also an online README file at [4]. The source BDF files are available from the project’s SourceForge page at [5], and the BDF files I’m attaching come from the source package at [6].

According to the project[4], this font is a derivation of older free fonts and enhanced with bitmaps made by online users. As such, it is licensed under the GPLv2 with a font embedding exception[4]:

[quote]
** GPL v2 license with font embedding exception:

As a special exception, if you create a document which uses this
font, and embed this font or unaltered portions of this font into
the document, this font does not by itself cause the resulting
document to be covered by the GNU General Public License. This
exception does not however invalidate any other reasons why the
document might be covered by the GNU General Public License. If you
modify this font, you may extend this exception to your version of
the font, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
[/quote]

It’s up to Rockbox developers whether to strip off this exception. Either way, the font is compatible with Rockbox’s license (GPLv2).

Links:
[1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?BitmapSong [4] http://www.wenq.org/index.cgi?Hero_README [5] http://sourceforge.net/projects/wqy/ [6] http://downloads.sourceforge.net/wqy/wqy-bitmapfont-bdf-gb18030-0.9.9-0.tar.gz?modtime=1194227675&big_mirror=0

9059RockboxPatchesFont/charsetLowWenQuanYi Unibit font2008-05-313 Task Description

This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2].

I’m adding this font because:
1. Currently there is no good Chinese font for Rockbox.
2. The best Chinese font (unifont) has unevenly sized Chinese characters, while this font has uniformly sized Chinese characters.

The attachments contain screenshots of the simulator, to show how this font would look like on the iPod Nano. I’ve also attached a screenshot using the Unifont font to show the uneven sizes of Chinese characters, for comparison. I don’t know about other languages, but I’d think other CJK languages work better in this font as well, due to the merging of WenQuanYi Bitmap Song.

According to the project[3], this font is made by combining the GNU Unifont (GPL), WenQuanYi Bitmap Song (GPL) and Fixed-16×8 (Public Domain) fonts. The maintainer of GNU Unifont also acknowledges this fact at [4].

This font is licensed under the GPLv2 with a font embedding exception[3]:

[quote]
** GPL v2 license with font embedding exception:

As a special exception, if you create a document which uses this
font, and embed this font or unaltered portions of this font into
the document, this font does not by itself cause the resulting
document to be covered by the GNU General Public License. This
exception does not however invalidate any other reasons why the
document might be covered by the GNU General Public License. If you
modify this font, you may extend this exception to your version of
the font, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
[/quote]

I don’t mind either way, but it would be up to Rockbox developers whether to strip off this exception. And either way, the font is compatible with Rockbox’s license (GPLv2).

The font I’m attaching is a modified version (and only the bdf); you can download the original version from [5]. My modification is:

— wqy-unibit.bdf.orig 2008-06-01 04:47:36.839752214 +0800
+++ wqy-unibit.bdf 2008-06-01 05:01:51.031748178 +0800
@@ -64,7 +64,7 @@
CHARSET_ENCODING “-1” CHARSET_COLLECTIONS “ASCII ISO8859-5 GB2312.1980 BIG5-0 KSC5601.1989-0 JISX0208.1997 ISO10646-1” ENDPROPERTIES
-CHARS 46443
+CHARS 46444
STARTCHAR uni0000
ENCODING 0
SWIDTH 500 0

This is because convbdf will emit a warning “Warning: DWIDTH spec > max FONTBOUNDINGBOX” when converting the font. This is because there are actually 46444 STARTCHAR entries, but only 46443 glyphs – the character “mu” is encoded as 181 and 956, with the exact same glyph. The generated .fnt file is exactly the same with or without my modification.

Additionally, this font is quite big so it’s a bit big on the screen of the iPod Nano. But it would be great on larger screens. Please take a look at the screenshots in the attachments.

Links:
[1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?Unibit_README [4] http://www.unifoundry.com/unifont.html [5] http://downloads.sourceforge.net/wqy/wqy-unibit-bdf-1.1.0-1.tar.gz?use_mirror=osdn

Showing tasks 1 - 13 of 13 Page 1 of 1

Available keyboard shortcuts

Tasklist

Task Details

Task Editing