All Projects

remote screen displays copy of part of main screen.

confirmed on iriver h300 simulator.
revesion: r29065
OS: Ubuntu 10.04

r28914(Vastly increase speed of SDL screen updates for RGB565) seems to cause this.

rockpaint: use rockbox_browse() to select .bmp file to load.(menu → Load)
text viewer: use rockbox_browse() to select font. (menu → Viewer Options (or Global Settings) → Font)

this implements suggestions discussed in mailing list ( FS#6321  - Universal Image Viewer(http://www.rockbox.org/mail/archive/rockbox-dev-archive-2010-11/0058.shtml))
get_image_type in image_decoder.c is changed as follows.
1. if it has supported image’s magick value and has assosiated file extension, returns corresponding IMAGE_*.
file will be loaded.
2. if it has supported image’s magick value but *doesn’t* have assosiated file extension, it warns that file extension might not be correct and returns corresponding IMAGE_* determined from the magick value.
file will be loaded.
3. if it *doesn’t* have supported image’s magick value but has supported image file’s file extension, returns corresponding IMAGE_* determined from the extension.
file will not be loaded, and error will be displayed. user can know something is wrong.
4. if it *doesn’t* have supported image’s magick value and *doesn’t* have supported image file’s file extension, returns IMAGE_UNKNOWN.
image viewer skips to next file silently.

get_pic_list imag in imageviewer.c is changed so that it create list of all file.
(if filtering is done at this point, initial loading would take longer, but not confirmed)

This patch makes it easier to use rockbox_browse().
- add struct browse_context to be passed to rockbox_browse.
- show proper title when selecting e.g. .wps file or .sbs file from the settings menu.
- use rockbox_browse() to view playlist catalog (see also  FS#11678 ).

*Known issue
browser is messed up if rockbox_browse() is called recursively.
to reproduce:
highlight audio file or playlist in browser → context menu → Playlist Catalog → View Catalog → context menu → Playlist Catalog → Add to Playlist → go back to browser.

future idea maight be to make rockbox_browse() available for generic purpose to select file.
e.g. use it to select file to save configure or playlist, to select .bmp file in rockpaint.

some setting items store full path while some other setting items store just filename without extension.
so it doesn’t make much sense to use same storage size (MAX_FILENAME+1=33) for both type of setting, and it already seems to cause issue on RaaA (see  FS#11575 ).
this patch increase buffer size of settings bellow to 80+1.
- rec_directory
- playlist_catalog_dir
- start_directory

1. select root directroy in the file
go to main menu → “Playlists” and select “Create
open file /root.m3u8 . all entry starts with
patch fix it to start with one
same for recording screen.

scrolling text in pictureflow isn’t so good beacse it keeps moving, it is hard to read first and last character in the line. it is terrible when the width of the line is a little longer than the lcd width.
this patch add scroll engine similar to the one in core.

attached theme i made sometimes causes freeze on the player.
i tried it on the ui simulator and the simulator crashes.
i tried both on windows with http://rasher.dk/rockbox/simulator/ and on ubuntu 10.04 with I built and result is same.

the theme is for gigabeat f/x.

1. Open Settings→Theme Settings→Browse Theme Files.
2. Select theme other than currently used.
3. shutdown and reboot.
the theme is not changed to selected.
if i select a font after loading theme and then shutdown and reboot, theme is changed to selected.

r28120 seems the cause. reverting the change solve the issue.

I use “rockbox” instead of “.rockbox” as rbdir so that my build doesn’t conflict with officical one.
if i run “make install PREFIX=/path/to/player”, it ignores rbdir setting and over write .rockbox directory on the player.
if i use “make zip”, rbdir is used but firmware binary (rockbox.gigabeat) is missing from the directory. also, temporal directory is not removed.
confirmed with r27964.

it converts %Vi|8|36|224|176|-|-|-| to %Vi(8,36,224,176,-,-)%Vb( at line 28. using r2668.

in current svn, reusing buffer works only if both skins don’t contais %X tag.
the cause is:
if the skin contains %X tag, string passed to skin_backdrop_load as backdrop is somthing like “sbsback.bmp|\n%Vi|14|66|212|224|1|000000|ffffff|\n…” and will be stored to bdrop→name as “sbsback.bmp|\n%Vi|14|66|212|224|1|0000”.
so, comparing passed backdrop and bdrop→name will always fail.

attached correct_reusing_backdrop.diff changes this like follows:
change size of bdrop→name to MAX_PATH,
use filename which is fullpath of the file for both comparing and stored value.

improve_set_as_backdrop.diff improve “Set as backdrop” functionality.
it fix that, after N times of failure of “Set As Backdrop” or “Clear Backdrop”, “Set As Backdrop” always fails until reloading a skin becase of lack of memory.
instead of allocating buffer by skin_buffer_alloc(), add new function skin_backdrop_getbuffer() and pass “-” as filename to get same buffer for the backdrop used in sb_set_backdrop().

this patch adds two items to database’s context menu with an audio file is selected.
one is Playlist Catalog and the other is Properties.
i think Properties is useful when navigating other than artist or album.

Johannes Schwarz pointed out that virtual keyboard lacks support for touchscreen. so i tried to add one.
but i don’t actually understand how touchscreen works and don’t have tagert to test on. so, feel free to improve, customize or even reject.
tocuh character to input a character.
tocuhing right side changes the page if there is more than one.
tocuh left/right side of edit line to move cursor left/right by one char.
morse input support is not added.
text on buttons is not localized.

probably this is not so usable especially for default keyboard with system font because of too small grid for character selection.
maybe it can be improved by defining something like MIN_GRID_SIZE and use it instead of font width or font height.

I noticed some redraw prblems using custom statusbar skin.

Target: Gigabeat X
Rockbxo version: r23989-091214

1. Right after exit text_editor plugin, list uses whole screen instead of sbs viewport.
2. If I keep pressing a button, sbs stops to update information.
e.g. if i keep pressing VOL UP buton, value of volume in sbs increases for a short period and then stops to increase.
And i release the button, the value jumps to correct value.
3. Informations are not update in setting menu unless press a button.
e.g. play any song and go to Setting → Sound Settings → Volume. current time in song is not updated.
there may be more screens that sbs is not updated unless press a button.

patch 01, 02 and 03 are fix for 1, 2 and 3 respectively.
also attached theme i used for testing.

with this patch, calendar for non-rtc targets would work as follows (nothing is changed for rtc targets).
1. first time the calendar plugin is started, it selects first day of month of year where month and year is when calendar plugin is build.
2. when the plugin exits, it saves current month and year to config file.
3. next time it is started, it select first day of saved month of year.

this patch adds new context, CONTEXT_MORSE_INPUT for keymaps and use it but CONTEXT_KEYBOARD while in morse code input mode in keyboard.
it’s purpose is to make it easier/possible to adapt more keymaps for morse input.
but i’m not sure if this is a way to go. doesn’t this make things complicated?

this patch is some improvements for gui/list.c
* add function list_get_nb_lines and replace duplicated codes to calculate number of lines by it.
* refine calculation of gui_list→start_item[screen] in function gui_list_put_selection_on_screen.
- tries to show as many items as possible. hopefully fix  FS#10054  without further glitches, iiuc the issue.
* remove trailing spaces and fix indents.

I set brightness setting to both top and bottom item of quickscreen.
In setting menu, pressing up button increases brightness and pressing down button decreases brightness.
but in the quick screen, it is reversed. i.e. pressing up button decreases brightness and pressing down button increases brightness.

EDIT: I’m using Gigabeat X, r23328.

This is previously posted to FS#7432.

This plugin displays lyrics in .lrc file synchronized with song being played.
See attached lrcplayer.txt for details.

chages from lrcplayer.3.patch (in FS#7432).
* disable reading id3 for low mem targets.
* ignore word time tags in enhanced .lrc format instead of displaying them.

This attempts to improve browsing font by creating font preview.
still needs some work.
* if buffer isn’t enough large to store all preview of fonts, fonts that weren’t loaded won’t ever displayed.
* text doesn’t scroll.

Currently, rockpaint always save the bitmap file which size is same as screen size regardless of the size of loaded bitmap.
This patch enables saving the bitmap as same size as loaded bitmap. Also, width/height can be changed if you want.

Confirmed with gigabeat X30, r22014, default settings.
how to reproduce:
1. show WPS.
2. connect USB.
3. disconnect USB and main menu will be shown.
4. go to browser. statusbar isn’t shown.
Once you go to wps and back to browser, statusbar will be shown again.

Opposite thing (i.e. statusbar is shown in browser) would happen if statusbar setting is set to off and use wps with statusbar enabled.

Attached patch seems to fix this issue but I’m not sure if this is correct fix.

In gigabeat f/x, you can scroll page up/down by pressing A+ UP/DOWN in list such as browser or playlist viewer.
but scrolling page up/down skips extra one line.
for example, open playlist by “Context Menu” → “Playlist” → “Ceiw “.
items from 1 to 19 will be displayed and 1st item will be pointed.
then, press A+DOWN and 21st item will be pointed.
imo, 20th item should be pointed.
if you simply press A+DOWN again, 23rd item won’t be shown.
the number would differ depending on lcd height and font.

this is because title is not taken account of when calcurating how many lines to skip.
here is a patch for this bug.

*Close file descriptor in highscore_load.
*Replace tabs with spaces.
*Change format of score in file.
Change format from “name:score:level” to “score:level:name”.
In this way, name can contain any kind of char including ‘:’ (but currentry, name doesn’t seems to be used) and settings_parseline can be used to parse string.
*make highscore_update to return the postion of newly added score.
return 0 if the score is not added.
this value can be used to display something like “New High Score #1”.
*change highscore_update, reverse the oder of scores.
Highest score is stored at the end of array and it is not intuitive.
*Modify rockblox to fit above change.
rockbox is the only plugin using highscore_update.

*Use same menu for both in-game and not in game.
-”Restart Level” and “Start Game” are combined as “Start New Game”.
“Restart Level” sounds like to restart the level I stoped for me. but it starts game from level 1.
-Show message “No game to resume” if “Resume Game” is selecetd while not in game. this is similar to chopper.
*fix typo “Difficult” to “Difficulty”.
*Fix the following issue.
pause game and enter menu. then resume game. the menu will stay shown untill game is unpaused. it is confusable.
With this patch, redraw the board and show “Paused”.
another way to fix it would be to force unpausing. i.e. somthing like “pause = false;”.
or do not allow to enter menu while the game is pausing.
I’m not sure which is the best.

Since Gigabeat F has menu button, there is a reason to use the button to go to the menu.
Change manual accordingly.

In “Set Time/Date” screen, instruction likes following is shown.
but pressing button A doesn’t revert changes…

SELECT = Set
A = Revert

enabled to use volume up/down to move cursor which are not used in keyboard,
because it’s a bit difficult to press A+Left/Right with one hand.

Confirmed with r21075.
I build rockbox for myself and noticed that there is two “lua.rock”s.
One is “build-dir/apps/plugins/lua/lua.rock” and the other is “build-dir/apps/plugins/lua.rock”.
The latter seems to be a loader of lua.ovl, but lua.ovl doesn’t exist.

this patch is some minor fixes to following plugins/files.

*text_editor
remember closing file descriptor.
*spacerocks
pause only if playing game when HOLD is enabled,
to fix bug that enabling and disabling HOLD in demo allows player to “resume” game.
*star
hide statusbars in menu so as not the bars to be drawn on title.
*rocklife
check result of open properly.
open in Rockbox seems to return negative value not only -1 when error.
iirc, open returns -2 when too many files are opened.
*apps/plugins/lib/helper.c
no need to check if rb is NULL since it should be initialized in loader.

*dict
*stopwatch
*keybox
*pegbox
replace ‘ROCKBOX_DIR “/rocks/(apps|games)/…“’ with ‘PLUGIN_(APPS|GAMES)_DIR “/…“‘.

*apps/keymaps/keymap-gigabeat.c
make source code look better.

*apps/plugins/spacerocks.c
*apps/plugins/star.c
*apps/plugins/sudoku/sudoku.h
*apps/plugin.c
*apps/plugin.h
replace tab with 4 spaces.

this patch makes plugin to set font to FONT_UI when exit them if it set to FONT_SYSFIXED.
what is problem is it affects the font of splash and it results in showing empty box if language is set to japanese, chinese, etc..

it might be easier/simpler to do it in plugin_load in apps/plugin.c after returning from a plugin.

this patch replaces menu of the following plugins by standard menu.

plugins using oldmenuapi:
doom
pacbox
reversi
solitaire
sudoku
random_folder_advance_config
fireworks
jpeg
mpegplayer
rockboy
viewer
zxbox
test_sampr
test_disk

plugins using its own menu:
jewels
chessclock

plugins whose menu is NOT replaced:
rockpaint
- this plugin has file browser and it needs some work to turn to standard menu.

this patch adds keymaps to the plugins section of the manual for Gigabeat S.
it may contains wrong keymaps.
this is my first time to work with manual. i hope not to break anything..

this patch corrects key instructions in plugins for gigabeat.

for gigabeat F/X
* blackjack
- change CENTER to SELECT for consistency.
- fix putting two strings to the same row.
* sliding_puzzle
- change OFF to POWER since gigabeat does not have button OFF.
* star
- correct key instruction which is out of date.

for gigabeat S
add key instructions to following plugins.
* blackjack
* flipit
* sliding_puzzle
* sokoban
* star

fix bug that causes buffer overflow when the file size is bigger than 128KiB (half of MAX_CHARS).
change concat to not add empty line at the end of file.
change a return value of menu to not make variable “changed” true after returning from Playback Control menu.
to confirm, open a file with text_editor, go straight to playback menu, close the menu and exit plugin.
you will be asked to save or ignore changes despite nothing is changed.
fix bug that Color setting will be lost after edit Extension when editing .colours file.

i tested on gigabeat X30 and it seems OK..
please check.

1. make duplicated code into function such as

 putting resources on borad,
 moving unit,
 attacking to opponent's territory and calculating result.

2. change function computer_war to avoid endless loop.
3. simplify redundancy conditionals.
4. handle canceling at selecting place or input number.
5. use while(1) loop instead of goto.
6. use system font when drawing score. (part of  FS#7593  ?)
this maybe fixes bugs reported at  FS#9962 ,  FS#9963 ,  FS#9965 .

please see attached picture.
the character of R, G, and B are in the left of screen and cursor is hidden by R.

I made a patch but I’m not sure if this is correct fix…

lcd_bitmap_transparent_part in firmware/target/arm/s3c2440/gigabeat-fx/lcd-meg-fx.c does not clip bitmap correctly.
this cause a problem that jewels appear strangely when they fall down from above on jewels plugin.

this fix is only copy from firmware/drivers/lcd-16bit.c.

this patch fixes these bugs.
1. curosr disappears when move to January from Dec.
curosr indicates 32, 33… 2. it shows empty memo when you select monday after memo is add.
this is because memos_in_memory is incremented improperly after memos are loaded.
3. weekly memos are also shown monthly.
e.g. add weekly memo to 1st September at first.
then, select 1st Octember, and it will show the memo you added to 1 September.

and I made some changes.
1. modify function save_memo to rename ‘~temp’ to ‘.memo’ instead of copying content.
2. look after array size.
3. modify some indent.

This patch will make calendar plugin available for the targets with RTC.
1. I added button maps just like other plugins and fixed some codes.
2. use rb→memset to initialize struct variables.
3. draw lines if the LCD is large enough.
4. use List Widget to show memos and menu API for edit menu.

I tested this on my Gigabeat F21 and on the sim.
Sorry for my bad English.