All Projects

@r24437

A little thinko crept into the rename logic.

If you have “Warn on Playlist Erase” enabled there are two paths that are possibly inconsistent.

1. Start a playlist
2. Play
3. Stop playback (or pause)
4. Attempt to start a new playlist
5. Get warning

Second path:

1. Start a playlist
2. Play
3. Reboot player (or Ctrl-C emulator and restart)
4. Attempt to start a new playlist
5. New playlist created straight away

However if you resume playback and then attempt step 4 you will get a warning.

While this behaviour in understandable (after all if the user cared about their lasy playlist they probably would resume) the behaviour is potentially inconsistent?

Fix off-by-one errors in grab_filename

format_track_path needs the length of the string not
it will start looking at uninitialised memory.

From 240b4eb19c0e167030bdbfe498f15596ca09316f Mon Sep 17 00:00:00
Alex Bennee
Wed, 22 Apr 2009 13:17:00
[PATCH] Clean up the MP4 metadata parsing.

The parser used to finish as soon as it saw an “mdat” atom and has
filesize. There is nothing that says all you metadata will
seen at this point. I’ve tweaked the parser to ensure it goes
way through the file scanning for metadata.

If tested this with an m4a of iTunes which mp4info parsed OK:

09:44 alex@danny/x86_64 [simdisk] >mp4info 03\ -\ This\ House\ Is\ Not\ for\
version
- This House Is Not for
Type
audio MPEG-4 AAC LC, 233.732 secs, 128 kbps, 44100 Hz Metadata Name: This House Is Not for Sale Metadata Artist: Ryan Adams Metadata Year: 2003 Metadata Album: Love Is Hell Part 1 Metadata track: 3 of 10 Metadata Disk: 1 of 1 Metadata Genre: Alt.Country Metadata Cover Art pieces: 1

However the file still won’t play on Rockbox, I assume because
that does the actual playing cannot deal with the
of the m4a. Interestingly it plays the other songs of

apps/metadata/mp4.c | 116 +++++++++++++++++++++++++++++++++++—————- 1 files changed, 80 insertions(+), 36 deletions(-)

The current attempt to deal with git repos fails if it’s not a svn-repo (which is won’t be if people have synced of the rockbox git repo). This patch makes the version script agnostic about git-svn and use Linux style id if git is detected.

While selecting a m4a for playing it crashes. Works on ipod sim build.

The Rockbox file browser has the ability to load new firmware by selecting an alternative rockbox.ipod. However this is rather pointless as the support files in “/.rockbox” will be for the old build.

This series of patches allow you to configure rockbox with an alternate directory:

../tools/configure –target=22 –ram=64 –type=N –rbdir=rockboxdev.alt

Which after building will give you a complete install zip file which extracts into “rockboxdev.alt”. Although this build will never be the primary build (the bootloader is hardwired for .rockbox) it does mean you can run a development build without having to break your existing working setup.

Before I started on fixing up the script to handle different potential
rockbox /’s I noticed it was a little rusty. This patch cleans up the
buildzip.pl script (Use GetOpts, user strict, basic sanity).