All Projects

IDProjectTask TypeCategorySeveritySummaryOpened
10030RockboxBugsUser InterfaceLowlatest nat sort fix still sorts wrong2009-03-17267 Task Description

In the never ending saga of strnatcmp the fix for 10029 sorts as
001
002
01
02

Attached is yet another attempt to get it right.

 9972 RockboxPatchesUser InterfaceLow Simplification of new strnatcmp 2009-03-011 Task Description

This patch removes compare_left function, from the new strnatcmp function, which is never called.

For each pass of the comparison, the characters being compared can be roughly grouped as; [0], [1-9], [spaces], and [everything else].

The first two loops strip and leading [0]’s and [spaces], leaving [1-9] and [everything else].

The “process run of digits” compares only digits, which would only be [1-9]. The ‘fractional’ variable will never equal 1 (true) and compare_left is never called.

Showing tasks 1 - 2 of 2 Page 1 of 1

Available keyboard shortcuts

Tasklist

Task Details

Task Editing