All Projects

Fix the clickable buttons on the ui-simulator background for Sansa Fuze+

(I didn’t set up a Rockbox git account, so could someone look this over and commit for me?)

Plugins that call rb→readdir() crash. (since r28929) (edit: r28929 not 29929)

When font glyphs are loaded from disk there are 3 file sections to read from: width data, offset data, and bitmap data. The number of disk seeks can be very much reduced by opening the font file with three separate file descriptors, each of which have a small cache. This is a small patch that opens additional file descriptors for width and offset data during glyph_cache_load(). The fd’s are closed after the initial load so it only uses two extra fd’s for a short time. It’s a bit of a kludge but it increases initial glyph loading speed about 600% for a cached font.

edit: the later patches save a glyph file for each font instead of the original solution immediately below. i.e. /.rockbox/fonts/15-Times.fnt would have a glyphcache file /.rockbox/fonts/15-Times.glyphcache. -FB

The font system is no longer saving the .glyphcache file. This file data is used to preload the most recently used glyphs in disk order when loading a cached font to reduce the number of disk seeks. I’m posting this fix for review because it changes the old behavior a bit. Doing this right should improve font loading, especially for non-English users.

1) Saves the LRU data of the cached font with the most glyphs in memory. It did use FONT_UI for a long time but that might not be the best choice anymore as ID3 tags might be displayed by a skin font.
2) Only overwrites the existing file if it has more LRU data.
3) Doesn’t write the file for less than 20 entries.
4) Removes a kludge in the glyph cache reading code for an old bug that no longer exists.

We should allocate font memory according to the number of glyphs needed because the font coverage can vary quite a bit between a small mono font and a large anti-aliased font for a given buffer size. It’s easy to do this now that font memory is reserved via buflib. This patch adds a global setting for the default number of glyphs for fonts rather than a fixed buffer size for each font. The setting is under Theme Settings>Glyphs to cache, which sets global_settings.glyphs (default 250).

Adds the function font_load_glyphs( char *path, int glyphs );
Adds a #define font_load_whole( char *path ); that tries to load the entire font into memory.
font_load_glyphs now checks if the specified number of glyphs would make the font_cache structure larger than the font file and if so, just loads the whole font file in memory instead.

This simply adds a format tag to make drop shadows for text in the while playing screen. The format of the tag is %as(2) where 2 is the number of pixels the shadow is offset down and right. The shadow is rendered in the viewport’s background color.

This would render white text with a black background offset one pixel down and right:
%Vf(ffffff)%Vb(000000)
%as(1)Text

These patches improve the allocation of font memory in the skin engine. Allocating memory in proportion to the glyph size is more efficient and if done right can reduce the disk reads while loading skin_fonts. There are two variations:

“Skin_fonts_extra_tag” adds a field to the load user font tag that explicitly specifies how many glyphs to allocate memory for. This allows paring down fonts that are just used for number display and allows forcing more allocation for international users who use more glyphs.
%Fl(3,16-GNU-Unifont.fnt) would become %Fl(3,16-GNU-Unifont.fnt,100). Supplying a dash allocates 256.

“Skin_fonts_smart_alloc” is a less ambitious patch that allocates space for 256 glyphs without changing the tag specification.

skin_font.c tries to load fonts that are already in memory because it compares a font name to a full path name. For example: “11-Nimbus” to “/.rockbox/fonts/11-Nimbus.fnt”

This synchronizes the remote display to the main on the virtual keyboard. Many remotes don’t have enough buttons to use the virtual keyboard independently. By synchronizing the main and remote and sending keyboard input to both screens the remote can be useful even without a full set of editing buttons. The displays show a panning window of the picker area. This saves about 1000 bytes on targets with remotes by not duplicating the keyboard picker buffer.

I’m not sure what to do with paging, input would be appreciated. For now I took it out and just made one big picker area, which allows the preservation of the layout in the custom keyboard layout file.

This patch makes no functional changes but simplifies the code by putting each user action into a separate function making the code more maintainable and allowing reuse of code in the future.

The purpose of this patch is to allow the simulator to load a background image when specifying the root directory. The current code ignores the –root option and tries to load from the current working directory. This patch will try to load the image from the parent of the given root directory.

This patch turns the simulator background into a clickable area. i.e. you click on the play button to press play. It also maps mouse scrollwheel events to rockbox scrollwheel events. This facilitates testing because you don’t have to move your hand between the mouse and keyboard. There are currently maps for Fuze, iPod, and e200. I would add the others if there is interest.