All Projects

The parser is barfing on syntactically correct statements, for example:

Checking /home/saint/Desktop/iLike Classic/Current/iLike Classic/wps/iLike.wps… WPS parsing failure
Error on line 67.
%?bp<%?bc<%t(1.0)%xd(Ea);%t(1.0)%xd(Eb)|%xd(Ec)>|%bl(1,1,21,10,image,B,backdrop,

    ^ 'Expected argument separator' Here

saint@saint-desktop:~/Development/Rockbox/development/rockbox/build$

“%?bp<%?bc<|>|>” parses correctly.

“%?bp<%?bc<%t(1.0)%xd(Ea);%t(1.0)%xd(Eb)|%xd(Ec)>|%bl(1,1,21,10,image,B,backdrop,C)>” is rejected by checkwps and isn’t displayed by either the sim or device.

“%?bp<%?bc<%t(1.0)%xd(Aa);%t(1.0)%xd(Ab)|%xd(Ac)>|%?bl<%xd(Ad)|%xd(Ad)|%xd(Ae)|%xd(Af)|%xd(Ag)|%xd(Ah)|%xd(Ai)|%xd(Aj)|%xd(Ak)|%xd(Al)|%xd(Am)|%xd(An)|%xd(Ao)|%xd(Ap)|%xd(Aq)|%xd(Ar)|%xd(As)|%xd(At)|%xd(Au)|%xd(Av)|%xd(Aw)|%xd(Ax)|%xd(Ay)|%xd(Az)»” is rejected by checkwps but is displayed correctly in the sim and on device.

[Saint]

Daily build (which?): git HEAD

It is my understanding that the recent changes to wpsbuild.pl (Idf5994f17b9750983d7bc3ef583540a8cdae1dde wpsbuild: Rewrite to fix various issues and support .fms) have caused an error with the default theme.

As the description states, the cabbiev2 .cfg is being generated with bogus paths, specifically for backdrop, icons, and viewer icons:

# cabbiev2.cfg generated by wpsbuild.pl
# cabbiev2.320x240x16.wps is made by Johannes Voggenthaler, Apoo Maha, Marc Guay, Alex Vanderpol, Jerry Lange, Keith Perri, Mark Fawcus, and Marianne Arnold with support from Rockbox developers and forums. Based on Cabbie by Yohann Misquitta.
#
wps: /.rockbox/wps/cabbiev2.wps
sbs: -
selector type: bar (gradient)
backdrop: backdrops/cabbiev2.bmp
filetype colours: -
foreground color: CCCCCC
background color: 000000
line selector start color: fde89e
line selector end color: b58c00
line selector text color: 000000
font: /.rockbox/fonts/15-Adobe-Helvetica.fnt
statusbar: top
iconset: icons/tango_icons.16×16.bmp
viewers iconset: icons/tango_icons_viewers.16×16.bmp
ui viewport: -

I was made aware of the cabbiev2 backdrop failing to be applied in the sim approximately a week ago by bertrik (iirc), and thought little of it at the time. Though I should have.
I didn’t check up on it, and I guess the missing icon(s) weren’t noticed by him at the time either(?).

I have had a brief look, and I have gathered some understanding of wpsbuild.pl, but so far my poking at it has simply angered the beast even more.

So, I pass this on to someone else more capable (and with more time) than I.

[Saint]

645680d-120510

The summary is pretty much it, %ax no longer horizontally mirrors viewports when the user lang is rtl. This pretty much fudges my localisation work…unless I want to declare two viewports for each UI item I want to shift conditional to language direction…which I *really* don’t want to do.

[Saint]

This serves as the new home for my theme project… This is carried over from my forum thread, now deprecated:
http://forums.rockbox.org/index.php/topic,28083.0.html

r00001:

- Remove “Touch Tabs” that mislead users into believing we supported touch gestures (namely screen swiping)
- Now using items already present on the WPS to launch contextual pop-ups.
- Touch the volume icon to launch the volume slider, or long press to mute/un-mute.
- Volume touch slider pop-up now respects when its in use, and won’t disappear on you when trying to adjust the volume.
- The HW volume rock will also launch the volume touch slider pop-up, but for a minimal timeout period. Volume changes initiated with the volume rocker will not time out whilst being manually adjusted with the touch slider now either.

Touch UI:
-Extended touch regions to be as large as possible, to accommodate both large fingers, and to tolerate some shifting off the touch element when changing values.
-Brand spanking new “touch screen soft-lock” initiated in the WPS by pressing and holding the “Now Playing” title bar. Press and hold again to release the soft-lock.
-Launch the “Files - Quickscreen - Context” pop-up by touching the album art if present, or the current track metadata if album art is not present.

Visual elements:
- Title-bar system completely reimplemented.
- Refined alignment in all areas.
- Shiny new anti-aliased fonts.
- New bitmaps in a lot of cases.
- Fix two graphical errors present in the 480×800 port.
- Allow for RTL langs and (presently limited) translation.
- Make textual viewports RTL aware.

Metadata display:
-Metadata display tweaks try to avoid blank lines in cases where metadata isn’t present, reshuffle with “sane” conditions based on the presence of the next field if something we expect to be present is missing and fall back to a known present default if all else fails.

General:
- Bring it up to current syntax and remove headers, footers, white space, and (now) needless comments used in theme files during testing/review.
- Massive code clean-up in a lot of places.

[Saint]

As the heading suggests, this one’s pretty simple.

Since RaaA was made to use the HW volume keys there has been a nasty side effect of the volume always defaulting to full on application start.

This is dangerous for ears, headphones/monitors, and the internal speaker.

The volume reached in this “blast” also seems to exceed RaaA’s maximum volume, so it seems as though the full range is not being used as well.

r28861

I’m getting data aborts when I attempt to initialise the database when using the current build, it finds all the files fine, but fails on the second step (after reboot) during the 1~9 count.
I had thought it was possibly dodgy metadata tags in a file(s) so I tried adding small chunks to the DB at a time, but it also failed there too.
I worked out that it’s not the files themselves from installing 3.7/.1 release build(s), the database updates and initialises as expected in these builds.
After that, if I then update the build to SVN head and add some tracks and update the database it aborts again so I have to turn auto update off and downgrade to the release build to add tracks to the database.
This is present for me on two different devices (iPod Colour 64GB CF and iPod Colour 60GB HDD).

r28861

iPod Colour shows horrible artefacts left on the screen for quite some time after shut-down.
More often than not in the form of a pair of jagged vertical lines in the approximate centre of the screen, spaced 1~2px apart.
Looking rather similar to a lightning strike.
Very occasionally (1 in 50 or so) a piece of the theme or statusbar is “left behind” in the same or similar way on shut-down and fades out very slowly over a period of minutes.
It happens on both manual and idle time-out shut-down, but seems to present more reliably when the device is shut-down manually.
This is present for me on two different devices (iPod Colour 64GB CF and iPod Colour 60GB HDD)
I have also tried the 3.7 and 3.7.1 release builds and the problem is present there also.
[St.]

24×24 Iconset for RaaAoA or other large screened targets:

Future RaaA’s (RaaAo<whatever>)
SDL App
mini2440
Cowon D2? ]– At a stretch
iPod Video? ]– At a stretch
… Other?

Pictureflow runs like a bag of ass since the WPS integration on these players, this fixes this.
Based on comments from the original author on what should probably happen here, works a charm.

Title says it all…boost stack size until NAND Panics no longer plague Nano2G

r27889

This patch makes a small adjustment to the iPod keymap which swaps Quickscreen and Context Menu around.

Long Menu == Context Menu
Long Select == Quickscreen

I find it a lot easier to use, personally…

[St.]

r27935

This patch adds a few small tweaks to lamp.rock

1 - Added colours: white, red, orange, yellow, green, blue, indigo, vielet, black
2 - Adjustable backlight brightness
3 - Ignore “Idle Timeout” (used to piss me off to no end while trying to use this plugin)

[St.]

r27820

Unsurprisingly, as the summary suggests the timeout value of the %t tag is broken, and always reverts to the default value of 2 seconds regardless as to what timeout value is set.

First noticed by pixelma and mentioned on IRC, clearly visible in DancePuff Duo (or any theme with a subline timeout greater or less than 2 seconds)

[St.]

I have updated some (for now, more to come) of the CabbieV2 WPS:

- To use viewports for all cases of images and text.
- Broken the WPS code into sections instead of one huge chunk
- Lightly commented the WPS code
- Arranged the code to be consistent between each of the targets
- Use a consistent header for each file
- Fixed some coding errors (no functional changes)

I intend to finish the remaining targets in the very near future.

In this patch:

- iAudio X5
- iPod Nano 1G
- iPod Nano 2G
- iPod Color/Photo
- iPod Video
- iRiver H10 5/6 GB - iRiver H10 20 GB - iRiver H320
- iRiver H340
- Packard Bell Vibe 500
- Sansa c200 Series

[St.]

Missing Tags from the Manual:

%ax

When prepended to a viewport declaration, the viewport will be horizontally mirrored if the user language is changed to an RTL language.
Alignment tags will also be mirrored also.

Supported Tags:
%Cl
%V
%Vl

Example: %ax%V(,,,,)

* %Vi(label,….) This viewport is used as Custom UI Viewport in case the theme doesn’t have a ui viewport set in the theme.cfg. Using ‘-’ for the label means it is used by default. Having this is strongly recommended since it makes you able to use Custom Status Bars with other themes. If label is set this viewport can be selectivly used as the Info Viewport using the %VI tag. *

%VI(label)

Set the Info Viewport to use the viewport labeled label

* %Vp(start,show if id3,show otherwise) Display the playlist viewer in the current viewport. The entire viewport will be used, so don’t expect other tags in the same viewport to work well
start - the offset from the current playing track for the playlist to start showing (0 is start at the current track, 1 is the next track, etc)
“show if id3” - Skin code to display if the track has been buffered (supported skins explained below)
“show otherwise” - Skin code to display if the track hasnt been buffered, really only the filename is know at this point. Supported Tags:
%pp
all tags starting in %i
most starting with %f
%pt
%s Example: %Vp|1|%pp - %it|%pp - %fn| will display the playlist position, then either the track title (from id3) or the filename. The viewer will display as many tracks as will fit in the viewport. *

%Sr

Use as a conditional to define options for left to right, or right to left languages.

Example: %?Sr<RTL|LTR>

Entirely similar to  FS#11469  %tm will not update unless you exit the fms and then re-enter it.
Tested with r27379 Nano1G Simulator.

used a simple line “%tm<Scan|Preset>” to test.

r25486
Nano 1/2G

Attempting to assign something to a “hotkey” ends in

Data abort
at 0000000A (0)

needing a hard reset… I can reproduce it easily enough in the WPS just by going into the context menu and trying to assign pitchscreen, delete, playlist catalogue, sound settings, playlist settings…so I guess everything (well, everything I’ve tried. I’m getting sick of hard resets).
Although when I try to set a hotkey in the Tree context menu it doesn’t end in a data abort needing a hard reset, it doesn’t actually set the hotkey either… In the tree, something flashes up when I try to set a hotkey (some form of splash) but its far too fast to read.

[St.]

r25139

Splash Screens:

Shutting Down
Scanning Disk
Plugin Returned Error
all the Database init stuff
probably quite a few more

Are all displayed in sysfont instead of userfont.

r24903 (has been present for much longer however, I first noticed it in 3.3 release build)

Alternating sublines “back up” if displayed in a conditional viewport.

I have no idea how to explain this odd behaviour any more clearly, so I believe its better when seen for oneself…so I have attached a TEST-WPS which accurately demonstrates the bug.
To reproduce this behaviour, load the TEST-WPS and commence playing a track, put hold on (this will flip the conditional viewport) and let the track play for 30~60 seconds or so, then take hold off…The sublines will alternate *really* fast (approx 0.1 second intervals) and seem to go through the ammount of alternations that *would* have been displayed if the viewport was in view (ie. the sublines normally alternate at 2 second intervals, and if hold is on for 60 seconds when hold is released the sublines alternate 30 times in rapid succession).

It seems to me that alternating sublines have no idea if the viewport is being displayed or not, and continue to queue the alternations…but that is an extremely uneducated guess.

Sorry for the wall of text, its kind of hard to explain in a concise fashion.

[St.]

r224615 (and lower) tested with iPod Nano 1st and 2nd Gen

There is a drawing issue with the sky/terrain in chopper that causes the sky and the terrain to switch colours periodically and the sky to be drawn overlapping the “chopper” (after playing for about 30~40 seconds or so is when it seems to be at its worst) when playing on the setting “steep”.

The flipping of the colours between sky and terrain is bad enough, but the fact that the sky then draws overlapping the chopper make it *almost* impossible to play when this happens, well it basically is impossible, though sometimes through sheer fluke you can manage to not hit anything until the screen flips back to normal again (the colour swapping/drawing issue only seems to last a few senconds or so each time) and attempt to carry on until the bug eventually kills you at a later stage :P

[St.]

r24581 (issue noticed on iPod Nano 1st Gen)

The title is fairly self explanitory, when attempting to select a backdrop via the context menu, it fails with the error message “Backdrop Failed”.
Loading the backdrop via a theme, config setting is OK however.

[St.]

r24506-100204

Icons for viewers in the “Open With…” context menu (possibly other menus also) are applied incorrectly.
I have attached a screendump showing the problem, and the iconset I am using.
Iconset contains Iconset.bmp, Viewers.bmp, and the Viewers.icons file.
The problem exists with the default (Tango) iconset also.

[St.]